Looks like a good package, thanks for contributing!

My feedback is, rather than have functions with many arguments that you 
have to name in the docs, why not take a record instead? You can even 
provide a default.

prettyFloat 
<http://package.elm-lang.org/packages/enetsee/typed-format/1.0.1/TypedFormat#prettyFloat>
 : { prefix : Maybe String, suffix : Maybe String,
showPos : Bool, sep : Char, decimalPoint : Char, decimalPlace : Int }
-> Format 
<http://package.elm-lang.org/packages/enetsee/typed-format/1.0.1/TypedFormat#Format>
 
a (Float -> a)

Also, for prettyFloat, will passing *Just ""* and *Nothing* as the first 
argument produce the same result? If so, it seems like you should drop the 
Maybe.

-- 
You received this message because you are subscribed to the Google Groups "Elm 
Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to elm-discuss+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to