Hi, thanks! and than you for your suggestions! I think that explaining in the beginning what you can learn from the post is a very good idea.
Thanks for your feedback because it was really helpful. Adrián El martes, 15 de noviembre de 2016, 23:14:47 (UTC+1), Wouter In t Velt escribió: > > Great article! > I really like the way that you take the reader step by step through > building a basic SPA, which even includes navigation and url parsing. > > Personally, I think it is fine to let the reader "play along" by making a > local copy and work on that. It would be useful if you point out that the > "localhost" links only work if reader already has elm-reactor running. But > I guess the point you are trying to make is that your app allows user to > type these urls in the browser. > Maybe keep the urls, but remove the links? > In general, it would be nice to have links to a working example, possibly > on gh-pages. > > As general feedback: Because it is quite a long read, adding an explicit > comment in the beginning of what you hope the reader will learn from your > post would be useful. E.g. "demonstrate that it is easy and fun to scale > Elm, that your code remains readable", or "if you are learning Elm, or want > to build a SPA for yourself, here is an example to get you started". > > I've added some minor comments on typo's and readibility in the article > too. > Suggest that you make function calls to imported functions explicit, e.g. > Navigation.newUrl instead of newUrl. > Make it clear to readers whether a function is defined by you or imported > (and from where). > > Thanks for sharing this! > Really useful, I have just begun to refactor a SPA to 0.18, and your > explanation of the new navigation module was really helpful. > -- You received this message because you are subscribed to the Google Groups "Elm Discuss" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
