Hi 2008/7/22 <[EMAIL PROTECTED]>: > > Note: > > * Only tested with qam256. >
I can test the qam64 lateron. I'd commit that one as it is. > > * I changed the EM2880_DVB_MAX_PACKETSIZE value to 752. Don't > know how you want to deal with that. > is there any specific reason for that? > > * To compile you have to create a top level tda18271/ directory and > copy tda18271.h into it. It's not in the kernel headers so you need > to get it from the kernel sources. > I'm a bit worried about this one since it's not backward compatible. When setting up the em28xx on older systems it shouldn't knock out other packaged drivers (eg. eeePC, shouldn't break the available Asus DVB package - it should more or less coexist). Could you do one more thing and only enable support for that device when the tda18271 is available (ifdef TUNER_PHILIPS_TDA18271 should be enough here)? > > * The following is getting set for cards that don't even have the > chip, so I boxed that stuff in. > > /* zl10353 powersaving */ > dvb_dev->init_override = dvb_dev->frontend->ops.init; > dvb_dev->frontend->ops.sleep = em28xx_zl10353_sleep; > dvb_dev->frontend->ops.init = em28xx_zl10353_init; > this driver version is currently mainly tested with zl10353 based devices. This part still needs some more work em28xx_zl10353_sleep can be renamed to em28xx_demod_sleep and em28xx_zl10353_init to em28xx_demod_init, those functions should contain the necessary demod handling. One goal is it to remove all device identifiers eg EM2888_BOARD_KWORLD_HYBRID_E329 from em2880-dvb.c and partly putting it into em28xx-cards.c. Alot information can be read from the device itself so that such an entry is not even necessary in all cases. > > * dvb_dmx_swfilter() is getting called twice in em2880-dvb.c and > corrupting data. > nice catch. Markus > _______________________________________________ > Em28xx mailing list > [email protected] > http://mcentral.de/mailman/listinfo/em28xx > > _______________________________________________ Em28xx mailing list [email protected] http://mcentral.de/mailman/listinfo/em28xx
