"Lennart Borgman" <[EMAIL PROTECTED]> writes: > I find it very hard to guess what this define is for without reading the > code. Using names like HAVE_MOUSE, HAVE_HOURGLASS makes it much more easy to > guess IMO. And I think that is important if you are scanning the code > quickly trying to find things, see the structure etc.
Conditional compilation constants are not comments. They are not there to assist your reading of the code, they are there to enable that code when appropriate. For that purpose, it is actually clearer to have the constants named so that the conditions under which that code is enabled is obvious. Having hourglass code surrounded by HAVE_HOURGLASS is not adding anything, because the actual conditions under which hourglass cursors are available depend on the platform, not some configure test. Also someone debugging why hourglass cursors do not work on a Mac might miss the fact that they are only enabled on X and W32, that is not likely if we list the real conditions under which that code is enabled. _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel
