Thank you for your kindly advices. At Mon, 20 Jun 2005 23:58:35 +0200, Juanma Barranquero wrote: > I'm using Visual Studio .NET 2003 and I'm getting "undefined > identifier" errors for LWA_ALPHA and WS_EX_LAYERED. They are on > WinUser.h, of course; I suppose it's a _WIN32_WINNT >= 0x0500 thing. > Perhaps the easiest fix is just define the constants yourself. I've done.
> - In frame.el you should use .... > (when (or (eq system-type 'windows-nt) (eq system-type 'darwin)) > > because it's nicer and easier to extend if someday other platforms > support transparent backgrounds. Done. > - Functions `set-active-alpha' and `set-inactive-alpha' do have an > argument ALPHA-VALUE, referred to in the docstring as ALPHA. Change > the name of the argument or fix the docstring, please. Done. > - Also, capitalize the interactive messages "active alpha: " and > "inactive alpha: " to "Active alpha: " and "Inactive alpha: " (it's > customary on interactive prompt). Doen. >> - Better still would be to document what the ALPHA-VALUE is and what >> is its range (0.0 to 1.0, I assume, but it is not said anywhere). ... > wraparound. It'd be better to restrict the values entered to the > correct range. Both done. Could you check new patch. Kind regards. T. Hiromatsu
transparency2.patch
Description: Binary data
_______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel
