Because url package was merged into Emacs long time ago, my understanding is it's meaningless to do xemacs feature test in url codes. So should these test codes be removed?
1. utl-http.el line 830-832: ,---- | 'face (if (featurep 'xemacs) | 'text-cursor | 'cursor) `---- may change to ,---- | 'face 'cursor `---- 2. url-dired.el line 32-34: ,---- | (if (featurep 'xemacs) | (define-key map [button2] 'url-dired-find-file-mouse) | (define-key map [mouse-2] 'url-dired-find-file-mouse)) `---- may change to ,---- | (define-key map [mouse-2] 'url-dired-find-file-mouse) `---- 3. url-file.el line 233-238: ,---- | (if (featurep 'xemacs) | (progn | (url-file-create-wrapper directory-files (url &optional full match nosort files-only)) | (url-file-create-wrapper file-truename (url &optional default))) | (url-file-create-wrapper directory-files (url &optional full match nosort)) | (url-file-create-wrapper file-truename (url &optional counter prev-dirs))) `---- may change to ,---- | (url-file-create-wrapper directory-files (url &optional full match nosort)) | (url-file-create-wrapper file-truename (url &optional counter prev-dirs)) `---- 4. url-handlers.el line 250-261.el: ,---- | (if (featurep 'xemacs) | (progn | ;; XEmacs specific prototypes | (url-handlers-create-wrapper | directory-files (url &optional full match nosort files-only)) | (url-handlers-create-wrapper | file-truename (url &optional default))) | ;; Emacs specific prototypes | (url-handlers-create-wrapper | directory-files (url &optional full match nosort)) | (url-handlers-create-wrapper | file-truename (url &optional counter prev-dirs))) `---- may change to ,---- | (url-handlers-create-wrapper | directory-files (url &optional full match nosort)) | (url-handlers-create-wrapper | file-truename (url &optional counter prev-dirs)) `---- 5. url-nfs.el line 90-95: ,---- | (if (featurep 'xemacs) | (progn | (url-nfs-create-wrapper directory-files (url &optional full match nosort files-only)) | (url-nfs-create-wrapper file-truename (url &optional default))) | (url-nfs-create-wrapper directory-files (url &optional full match nosort)) | (url-nfs-create-wrapper file-truename (url &optional counter prev-dirs))) `---- may change to ,---- | (url-nfs-create-wrapper directory-files (url &optional full match nosort)) | (url-nfs-create-wrapper file-truename (url &optional counter prev-dirs)) `---- _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel
