[elpa] 121/352: Välitetään kaikki tiedot funktiolle wcheck-make-overlay

[Stefan Monnier]

monnier pushed a commit to branch master
in repository elpa.

commit 1a34e6d0c98e38983ab3c28b628f4b26c9664818
Author: Teemu Likonen <tliko...@iki.fi>
Date:   Thu Jul 23 12:40:30 2009 +0000

    Välitetään kaikki tiedot funktiolle wcheck-make-overlay
    
    Tätä funktiota kutsutaan sen verran tiheään tahtiin, että funktio
    kannattaa pitää mahdollisimman yksinkertaisena ja välttää turhaa työtä.
    Siispä tarpeelliset tiedot välitetään nyt funktiolle parametreina,
    jottei niitä tarvitse joka kerta erikseen selvittää. Tällä perutaan
    muutos r2783.
---
 wcheck-mode.el |   15 +++++++--------
 1 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/wcheck-mode.el b/wcheck-mode.el
index 2e68b89..6bcffd9 100644
--- a/wcheck-mode.el
+++ b/wcheck-mode.el
@@ -814,6 +814,7 @@ visible in BUFFER within position range from BEG to END."
                (r-start (wcheck-query-language-data language 'regexp-start t))
                (r-end (wcheck-query-language-data language 'regexp-end t))
                (syntax (eval (wcheck-query-language-data language 'syntax t)))
+               (face (wcheck-query-language-data language 'face t))
                (case-fold-search
                 (wcheck-query-language-data language 'case-fold t))
                regexp old-point)
@@ -841,7 +842,7 @@ visible in BUFFER within position range from BEG to END."
                         (t
                          ;; Make an overlay.
                          (wcheck-make-overlay
-                          buffer (match-beginning 1) (match-end 1))))
+                          buffer face (match-beginning 1) (match-end 1))))
                   (setq old-point (point)))))))))))
 
 
@@ -947,13 +948,11 @@ according to A's and all overlapping A B ranges are 
combined."
 ;;; Overlays
 
 
-(defun wcheck-make-overlay (buffer beg end)
-  "Create an overlay for use with `wcheck-mode'.
-Create an overlay in BUFFER from range BEG to END. Use overlay's
-\"face\" property as configured in `wcheck-language-data'."
-  (let* ((language (wcheck-get-data :buffer buffer :language))
-         (overlay (make-overlay beg end buffer))
-         (face (wcheck-query-language-data language 'face t)))
+(defun wcheck-make-overlay (buffer face beg end)
+  "Create an overlay to mark text.
+Create an overlay in BUFFER from range BEG to END. Put FACE as
+the overlay's \"face\" property."
+  (let ((overlay (make-overlay beg end buffer)))
     (dolist (prop `((wcheck-mode . t)
                     (face . ,face)
                     (modification-hooks . (wcheck-remove-changed-overlay))