branch: externals/denote
commit 00632408ed4875eb28d28aa1f04f2e98099a253a
Author: Protesilaos Stavrou <[email protected]>
Commit: Protesilaos Stavrou <[email protected]>

    Remove :reverse parameter from 'denote-links' Org dynamic block
    
    We do not expose this feature to the commands we provide. Adding it
    here creates inconsistencies, such as, for example, with the
    'denote-files' Org dynamic block. I prefer to remove this option than
    to see its proliferation.
---
 denote-org-dblock.el | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/denote-org-dblock.el b/denote-org-dblock.el
index ce45555364..c278896e52 100644
--- a/denote-org-dblock.el
+++ b/denote-org-dblock.el
@@ -50,8 +50,7 @@
      (read-regexp "Search for notes matching REGEX: " nil 
'denote-link--add-links-history)))
   (org-create-dblock (list :name "denote-links"
                            :regexp regexp
-                           :id-only nil
-                           :reverse nil))
+                           :id-only nil)
   (org-update-dblock))
 
 (org-dynamic-block-define "denote-links" 'denote-org-dblock-insert-links)
@@ -61,8 +60,7 @@
 Used by `org-dblock-update' with PARAMS provided by the dynamic block."
   (let* ((regexp (plist-get params :regexp))
          (rx (if (listp regexp) (macroexpand `(rx ,regexp)) regexp))
-         (block-name (plist-get params :block-name))
-         (denote-link-add-links-sort (plist-get params :reverse)))
+         (block-name (plist-get params :block-name)))
     (when block-name
       (insert "#+name: " block-name "\n"))
     (denote-add-links rx (plist-get params :id-only))

Reply via email to