branch: externals/standard-themes
commit b25ea35a3aca32e5790d005f58ff85cd43c525dd
Author: Protesilaos Stavrou <[email protected]>
Commit: Protesilaos Stavrou <[email protected]>
DEPRECATE standard-themes-fringes; use palette overrides instead
We already have a powerful system of palette overrides where the user
can specify any colour for each key in the palette. This means that
instead of a hardcoded value for an "intense" or "subtle" style, we
give the user the freedom to pick exactly the hue and intensity they
prefer.
The user options for palette overrides are:
- standard-themes-common-palette-overrides
- standard-dark-palette-overrides
- standard-light-palette-overrides
---
standard-dark-theme.el | 1 +
standard-light-theme.el | 1 +
standard-themes.el | 28 ++--------------------------
3 files changed, 4 insertions(+), 26 deletions(-)
diff --git a/standard-dark-theme.el b/standard-dark-theme.el
index cf863c7fa4..c69dd8e219 100644
--- a/standard-dark-theme.el
+++ b/standard-dark-theme.el
@@ -129,6 +129,7 @@
(cyan-graph-1-bg "#00808f")
;; Special hues
+ (bg-fringe bg-dim)
(bg-mode-line "#505050") (bg-mode-line-inactive "#323232")
(bg-accent "#ffc200")
(bg-completion "#254b5f")
diff --git a/standard-light-theme.el b/standard-light-theme.el
index a4fcf16b82..c8bfe4b75a 100644
--- a/standard-light-theme.el
+++ b/standard-light-theme.el
@@ -129,6 +129,7 @@
(cyan-graph-1-bg "#afefff")
;; Special hues
+ (bg-fringe bg-dim)
(bg-mode-line "#b3b3b3") (bg-mode-line-inactive "#e5e5e5")
(bg-accent "#0000cc")
(bg-completion "#bfe8ff")
diff --git a/standard-themes.el b/standard-themes.el
index ef714272b6..85a3df5471 100644
--- a/standard-themes.el
+++ b/standard-themes.el
@@ -282,22 +282,6 @@ Other examples:
(const :tag "More intense background (also override text color)"
intense))
:link '(info-link "(standard-themes) Style of region highlight"))
-(defcustom standard-themes-fringes 'subtle
- "Control the visibility of fringes.
-
-When the value is nil, do not apply a distinct background color.
-
-With a value of `subtle', use a gray background color that is
-visible yet close to the main background color.
-
-With `intense', use a more pronounced gray background color."
- :group 'standard-themes
- :package-version '(standard-themes . "1.0.0")
- :type '(choice
- (const :format "[%v] %t\n" :tag "No visible fringes" nil)
- (const :format "[%v] %t\n" :tag "Subtle gray background" subtle)
- (const :format "[%v] %t\n" :tag "Intense gray background" intense))
- :link '(info-link "(standard-themes) Fringe visibility"))
(defcustom standard-themes-links nil
"Set the style of links.
@@ -350,6 +334,7 @@ Please refer to their documentation strings."
(const :tag "Bold font weight" bold)
(const :tag "Italic font slant" italic))
:link '(info-link "(standard-themes) Link style"))
+(make-obsolete-variable 'standard-themes-fringes nil "2.0.0")
(defcustom standard-themes-prompts nil
"Control the style of prompts (e.g. minibuffer, REPL).
@@ -455,15 +440,6 @@ represents."
(when standard-themes-variable-pitch-ui
(list :inherit 'variable-pitch)))
-(defun standard-themes--fringe (mainbg intensebg)
- "Conditional use of background colors for fringes.
-MAINBG is the default. INTENSEBG should be a prominent gray
-value."
- (pcase standard-themes-fringes
- ('intense (list :background intensebg))
- ('subtle (list :background mainbg))
- (_ (list :background 'unspecified))))
-
(defun standard-themes--alist-or-seq (properties alist-key seq-pred
seq-default)
"Return value from alist or sequence.
Check PROPERTIES for an alist value that corresponds to
@@ -918,7 +894,7 @@ Optional prefix argument MAPPINGS has the same meaning as
for
`(elisp-shorthand-font-lock-face ((,c :inherit italic)))
`(error ((,c :inherit bold :foreground ,err)))
`(escape-glyph ((,c :foreground ,warning)))
- `(fringe ((,c ,@(standard-themes--fringe bg-dim bg-active) :foreground
,fg-main)))
+ `(fringe ((,c :background ,bg-fringe :foreground ,fg-main)))
`(header-line ((,c :inherit standard-themes-ui-variable-pitch :background
,bg-dim)))
`(header-line-highlight ((,c :inherit highlight)))
`(help-argument-name ((,c :foreground ,prose-verbatim)))
