branch: externals/rt-liberation
commit c97eff6716c2438f9052b4641fa6128bf759af96
Author: Yoni Rabkin <[email protected]>
Commit: Yoni Rabkin <[email protected]>
Release version 6.
---
NEWS | 10 ++++++++++
rt-liberation-gnus.el | 12 ++++++------
rt-liberation-org.el | 4 ++--
rt-liberation.el | 20 ++++++++++----------
4 files changed, 28 insertions(+), 18 deletions(-)
diff --git a/NEWS b/NEWS
index 317a783d15..337365b1f7 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,13 @@
+New in version 6
+
+ * Code cleanup and fix compilation warnings.
+
+
+New in version 5
+
+ * Minor bug fix.
+
+
New in version 4
* "N" in viewer now reverts buffer before jumping to latest.
diff --git a/rt-liberation-gnus.el b/rt-liberation-gnus.el
index 521917a235..eb16c33a8c 100644
--- a/rt-liberation-gnus.el
+++ b/rt-liberation-gnus.el
@@ -139,19 +139,19 @@ OPTIONS association list of options.
(defun rt-liber-gnus-content-to-string ()
"Return the current content section as a string"
(rt-liber-gnus-with-ticket-buffer
- (goto-char (point-at-eol))
+ (goto-char (line-end-position))
(when
(not
(or (re-search-backward rt-liber-content-regexp (point-min) t)
(re-search-forward rt-liber-content-regexp (point-max) t)))
(error "no content sections found"))
(save-excursion
- (goto-char (point-at-bol))
- (re-search-forward "^Content: " (point-at-eol) nil)
+ (goto-char (line-beginning-position))
+ (re-search-forward "^Content: " (line-end-position) nil)
(let ((start (point))
text)
(re-search-forward "^[[:alpha:]]+:" (point-max) t)
- (goto-char (point-at-bol))
+ (goto-char (line-beginning-position))
(when (= 0 (length (buffer-substring-no-properties start (point))))
(error "empty content section"))
(setq text (buffer-substring-no-properties start (point)))
@@ -230,8 +230,8 @@ OPTIONS association list of options.
"Display the ticket at point."
(interactive)
(save-excursion
- (goto-char (point-at-bol))
- (re-search-forward rt-liber-gnus-subject-regexp (point-at-eol) nil))
+ (goto-char (line-beginning-position))
+ (re-search-forward rt-liber-gnus-subject-regexp (line-end-position) nil))
(let ((match (match-string-no-properties 1)))
(when (not match)
(error "no ticket number found in subject line"))
diff --git a/rt-liberation-org.el b/rt-liberation-org.el
index 7696b681c2..9c20f64bf3 100644
--- a/rt-liberation-org.el
+++ b/rt-liberation-org.el
@@ -28,8 +28,8 @@
(defun rt-org-open (link)
"Opens the rt LINK.
- Open the rt ticket (for links starting with 'id:') or run
- the query (for links starting with 'query:')."
+ Open the rt ticket (for links starting with `id:') or run
+ the query (for links starting with `query:')."
(cond
((string-match "^id:\\([^/]+\\)\\(/\\(.+\\)\\)?" link)
(let ((id (match-string 1 link))
diff --git a/rt-liberation.el b/rt-liberation.el
index 397cea81f6..bacaf1666f 100644
--- a/rt-liberation.el
+++ b/rt-liberation.el
@@ -5,7 +5,7 @@
;; Author: Yoni Rabkin <[email protected]>
;; Authors: Aaron S. Hawley <[email protected]>, John Sullivan
<[email protected]>
;; Maintainer: Yoni Rabkin <[email protected]>
-;; Version: 5
+;; Version: 6
;; Keywords: rt, tickets
;; Package-Type: multi
;; url: http://www.nongnu.org/rtliber/
@@ -254,15 +254,15 @@ The ticket's priority is compared to the variable
(defun rt-liber-ticketlist-browser-redraw-f (ticket)
"Display TICKET."
(insert (rt-liber-format "[%c %i %S]" ticket))
- (add-text-properties (point-at-bol)
- (point-at-eol)
+ (add-text-properties (line-beginning-position)
+ (line-end-position)
'(face rt-liber-ticket-face))
(when (rt-liber-high-priority-p ticket)
(let ((p (point)))
(insert (format " HIGH PRIORITY (%d)"
(rt-liber-ticket-priority-only ticket)))
(add-text-properties p
- (point-at-eol)
+ (line-end-position)
'(face rt-liber-priority-ticket-face))))
(newline)
@@ -831,14 +831,14 @@ returned as no associated text properties."
(mapcar
(lambda (field-symbol)
(re-search-forward (format "^%s:" (symbol-name field-symbol)) end
nil)
- (cons field-symbol (buffer-substring (1+ (point)) (point-at-eol))))
+ (cons field-symbol (buffer-substring (1+ (point))
(line-end-position))))
rt-field-list))
;; content
(goto-char start)
(let ((content-start (re-search-forward "^Content: " end nil))
(content-end (progn
(re-search-forward "^Creator: " end nil)
- (point-at-bol))))
+ (line-beginning-position))))
(append section-field-alist
`(,(cons 'Content
(buffer-substring content-start
@@ -860,7 +860,7 @@ returned as no associated text properties."
section-list)
(while (re-search-forward rt-liber-viewer-section-header-regexp
(point-max) t)
(setq section-point-list (append section-point-list
- (list (point-at-bol)))))
+ (list (line-beginning-position)))))
(when (not section-point-list)
(error "no history detail sections found"))
(setq section-point-list (append section-point-list
@@ -1048,7 +1048,7 @@ ASSOC-BROWSER if non-nil should be a ticket browser."
(message "no next section"))
(t
(recenter rt-liber-viewer-recenter)))
- (goto-char (point-at-bol))))
+ (goto-char (line-beginning-position))))
(defun rt-liber-viewer-last-communicate-in ()
(interactive)
@@ -1061,7 +1061,7 @@ ASSOC-BROWSER if non-nil should be a ticket browser."
(if (not last)
(error "no communcations found")
(recenter rt-liber-viewer-recenter)
- (goto-char (point-at-bol)))))
+ (goto-char (line-beginning-position)))))
(defun rt-liber-viewer-previous-section-in ()
(interactive)
@@ -1075,7 +1075,7 @@ ASSOC-BROWSER if non-nil should be a ticket browser."
(message "no previous section"))
(t
(recenter rt-liber-viewer-recenter)))
- (goto-char (point-at-bol))))
+ (goto-char (line-beginning-position))))
(defconst rt-liber-viewer-mode-map
