branch: elpa/gptel
commit e1dc99096a26ef8a79a081d07a7fa494da46c425
Author: Karthik Chikmagalur <karthikchikmaga...@gmail.com>
Commit: Karthik Chikmagalur <karthikchikmaga...@gmail.com>
gptel: Don't use generate-new-buffer
When creating temp buffers for rewriting and Org conversion, use
`get-buffer-create' and `generate-new-buffer-name' instead of
`generate-new-buffer'. The arity of `generate-new-buffer' changed
in Emacs 28, and our call to this with a second arg causes trouble
in Emacs 27.1 We can switch after dropping support for 27.1.
* gptel-org.el (gptel--stream-convert-markdown->org): Make the
above change. (#724)
* gptel-rewrite.el (gptel--suffix-rewrite): Make the above change,
and also use a temp buffer with buffer hooks inhibited to avoid
querying when the buffer is killed. It is not clear what is
setting up this hook, but in any case nothing of this sort should
run in the gptel-rewrite result accumulation buffer. (#730)
---
gptel-org.el | 3 ++-
gptel-rewrite.el | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/gptel-org.el b/gptel-org.el
index 8a0a5b83e2..eb4ded7693 100644
--- a/gptel-org.el
+++ b/gptel-org.el
@@ -617,7 +617,8 @@ START-MARKER is used to identify the corresponding process
when
cleaning up after."
(letrec ((in-src-block nil) ;explicit nil to address BUG #183
(in-org-src-block nil)
- (temp-buf (generate-new-buffer " *gptel-temp*" t))
+ (temp-buf ; NOTE: Don't use `generate-new-buffer' until we drop
support for Emacs 27.1 (#724)
+ (get-buffer-create (generate-new-buffer-name " *gptel-temp*") t))
(start-pt (make-marker))
(ticks-total 0) ;MAYBE should we let-bind case-fold-search
here?
(cleanup-fn
diff --git a/gptel-rewrite.el b/gptel-rewrite.el
index e7e1ab939b..85159e7e4e 100644
--- a/gptel-rewrite.el
+++ b/gptel-rewrite.el
@@ -632,7 +632,8 @@ generated from functions."
(make-overlay (region-beginning) (region-end) nil
t))))
(overlay-put ov 'category 'gptel)
(overlay-put ov 'evaporate t)
- (cons ov (generate-new-buffer "*gptel-rewrite*")))
+ ;; NOTE: Don't use `generate-new-buffer' until we drop support
for Emacs 27.1 (#724)
+ (cons ov (get-buffer-create (generate-new-buffer-name "
*gptel-rewrite*") t)))
:callback #'gptel--rewrite-callback)
;; Move back so that the cursor is on the overlay when done.
(unless (get-char-property (point) 'gptel-rewrite)
