branch: externals/denote
commit e8f9e22892e48d2e5bc3ed7be6cb5ef370870049
Author: Protesilaos Stavrou <i...@protesilaos.com>
Commit: Protesilaos Stavrou <i...@protesilaos.com>
Remove the custom revert-buffer-function of denote-sort-dired
I think we do not need it anymore and we had a FIXME for it, anyway.
Thanks to mjkalyan for reporting the problem with revert-buffer and
for testing this change:
<https://github.com/protesilaos/denote/pull/595#issuecomment-2853268654>.
---
denote.el | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/denote.el b/denote.el
index 5f6d32d717..9a5380218a 100644
--- a/denote.el
+++ b/denote.el
@@ -1726,15 +1726,7 @@ When called from Lisp, the arguments are a string, a
symbol among
(buffer-name (funcall denote-sort-dired-buffer-name-function
files-matching-regexp component reverse-sort exclude-rx)))
(setq denote-sort--dired-buffer dired-buffer)
(with-current-buffer dired-buffer
- (rename-buffer buffer-name :unique)
- (setq-local revert-buffer-function
- (lambda (&rest _)
- ;; FIXME 2025-01-04: Killing the buffer has
- ;; the unintended side effect of affecting the
- ;; window configuration when we call
- ;; `denote-update-dired-buffers'.
- (kill-buffer dired-buffer)
- (denote-sort-dired files-matching-regexp component
reverse-sort exclude-rx))))
+ (rename-buffer buffer-name :unique))
buffer-name)
(message "No matching files for: %s" files-matching-regexp))))
