branch: externals/denote
commit 81d392bf33d19c8e7398d2d380ac62afa0ae4331
Author: Protesilaos Stavrou <i...@protesilaos.com>
Commit: Protesilaos Stavrou <i...@protesilaos.com>

    Check for existing file earlier in denote--prepare-note
---
 denote.el | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/denote.el b/denote.el
index 14366e6771..e0b2d5a699 100644
--- a/denote.el
+++ b/denote.el
@@ -2917,10 +2917,10 @@ Arguments TITLE, KEYWORDS, DATE, ID, DIRECTORY, 
FILE-TYPE,
 TEMPLATE, and SIGNATURE should be valid for note creation."
   (let* ((path (denote-format-file-name
                 directory id keywords title (denote--file-extension file-type) 
signature))
-         (buffer (find-file path))
+         (buffer (if (file-regular-p path)
+                     (user-error "A file named `%s' already exists" path)
+                   (find-file path)))
          (header (denote--format-front-matter title date keywords id signature 
file-type)))
-    (when (file-regular-p path)
-      (user-error "A file named `%s' already exists" path))
     (with-current-buffer buffer
       (insert header)
       (insert (cond

Reply via email to