branch: externals/modus-themes
commit 4fd8cdfc552e7e1e6a96625a752ab612706b15e3
Author: Protesilaos Stavrou <[email protected]>
Commit: Protesilaos Stavrou <[email protected]>

    Update to modus-themes version 5.1.0
---
 CHANGELOG.org         | 38 ++++++++++++++++++++++++++++++++++++++
 doc/modus-themes.info | 20 ++++++++++----------
 doc/modus-themes.org  | 26 +++++++++++++-------------
 modus-themes.el       |  2 +-
 4 files changed, 62 insertions(+), 24 deletions(-)

diff --git a/CHANGELOG.org b/CHANGELOG.org
index 663bb2dc83..660c4d65df 100644
--- a/CHANGELOG.org
+++ b/CHANGELOG.org
@@ -15,6 +15,44 @@ For further details, please consult these additional 
resources:
 + Manual :: <https://protesilaos.com/emacs/modus-themes>
 + Screenshots :: <https://protesilaos.com/emacs/modus-themes-pictures>
 
+* 5.1.0 on 2025-11-07
+:PROPERTIES:
+:CUSTOM_ID: h:86a4b45a-14e0-45f1-9625-969ad966b9ff
+:END:
+
+This version fixes a critical bug in the ~modus-themes-with-colors~
+macro. In short, it was not working as before or was not working at
+all. Now it should do the right thing.
+
+Thanks to Alexandr Semenov for reporting a relevant bug in issue 170
+and for helping me test the results: 
<https://github.com/protesilaos/modus-themes/issues/170>.
+
+Thanks to Stéphane Marks for testing some configurations with the
+latest stable Emacs version as well as with builds from emacs.git.
+This was done via a private channel and I am sharing this information
+with permission.
+
+Also thanks to Stefan Monnier for monitoring my commits as I was
+trying to refactor the ~modus-themes-with-colors~ macro. Some comments
+were posted on the emacs-devel mailing list, as well as a patch that I
+ended up applying and then reverting (check the commit log for the
+technicalities): 
<https://lists.gnu.org/archive/html/emacs-devel/2025-11/msg00114.html>.
+
+Apologies to everyone for the inconvenience! This was a tricky bug.
+The good thing is that it compelled me to improve several parts of the
+code.
+
+This version also includes a clarification in the manual about
+building a theme on top of Modus:
+
+- Web page :: Visit 
<https://protesilaos.com/emacs/modus-themes#h:86eb375b-9be4-43ce-879a-0686a524a63b>.
+- Info manual :: Evaluate ~(info "(modus-themes) Build on top of the Modus 
themes")~.
+
+In short, it mentions that a theme exists in an appropriately named
+file that is part of the ~custom-theme-load-path~. Thanks to Ashton
+Wiersdorf for asking a related question in issue 171:
+<https://github.com/protesilaos/modus-themes/issues/171>.
+
 * 5.0.0 on 2025-11-01
 :PROPERTIES:
 :CUSTOM_ID: h:9232615a-02d7-4376-90a6-7e7570ac1c1e
diff --git a/doc/modus-themes.info b/doc/modus-themes.info
index dd6af827c4..35b8c47ab5 100644
--- a/doc/modus-themes.info
+++ b/doc/modus-themes.info
@@ -43,11 +43,11 @@ customization options for the Modus themes, and provides 
every other
 piece of information pertinent to them.
 
    The documentation furnished herein corresponds to stable version
-5.0.0, released on 2025-11-01.  Any reference to a newer feature which
+5.1.0, released on 2025-11-07.  Any reference to a newer feature which
 does not yet form part of the latest tagged commit, is explicitly marked
 as such.
 
-   Current development target is 5.1.0-dev.
+   Current development target is 5.2.0-dev.
 
    • Package name (GNU ELPA): ‘modus-themes’
    • Official manual: <https://protesilaos.com/emacs/modus-themes>
@@ -6168,9 +6168,9 @@ Ideas and user feedback
      Kazmier, Peter Wu, Philip Kaludercic, Pierre Téchoueyres,
      Przemysław Kryger, Robert Hepple, Roman Rudakov, Russell Sim, Ryan
      Phillips, Rytis Paškauskas, Rudolf Adamkovič, Sam Kleinman, Samuel
-     Culpepper, Saša Janiška, Shreyas Ragavan, Simon Pugnet, Steve
-     Downey, Tassilo Horn, Thanos Apollo, Thibaut Verron, Thomas
-     Heartman, Togan Muftuoglu, Tony Zorman, Trey Merkley, Tomasz
+     Culpepper, Saša Janiška, Shreyas Ragavan, Simon Pugnet, Stéphane
+     Marks, Steve Downey, Tassilo Horn, Thanos Apollo, Thibaut Verron,
+     Thomas Heartman, Togan Muftuoglu, Tony Zorman, Trey Merkley, Tomasz
      Hołubowicz, Toon Claes, Uri Sharf, Utkarsh Singh, Vincent Foley,
      Zoltan Kiraly.  As well as users: Ben, CsBigDataHub1, Emacs
      Contrib, Eugene, Fourchaux, Fredrik, Moesasji, Nick, Summer Emacs,
@@ -7013,11 +7013,11 @@ Node: Sources of the themes257015
 Node: Issues you can help with257911
 Node: Patches require copyright assignment to the FSF259303
 Node: Acknowledgements261525
-Node: GNU Free Documentation License266064
-Node: Indices291227
-Node: Function index291406
-Node: Variable index295601
-Node: Concept index299964
+Node: GNU Free Documentation License266081
+Node: Indices291244
+Node: Function index291423
+Node: Variable index295618
+Node: Concept index299981
 
 End Tag Table
 
diff --git a/doc/modus-themes.org b/doc/modus-themes.org
index 801c47e75b..4398350557 100644
--- a/doc/modus-themes.org
+++ b/doc/modus-themes.org
@@ -4,9 +4,9 @@
 #+language: en
 #+options: ':t toc:nil author:t email:t num:t
 #+startup: content
-#+macro: stable-version 5.0.0
-#+macro: release-date 2025-11-01
-#+macro: development-version 5.1.0-dev
+#+macro: stable-version 5.1.0
+#+macro: release-date 2025-11-07
+#+macro: development-version 5.2.0-dev
 #+macro: file @@texinfo:@file{@@$1@@texinfo:}@@
 #+macro: space @@texinfo:@: @@
 #+macro: kbd @@texinfo:@kbd{@@$1@@texinfo:}@@
@@ -5989,16 +5989,16 @@ The Modus themes are a collective effort.  Every bit of 
work matters.
   Philip Kaludercic, Pierre Téchoueyres, Przemysław Kryger, Robert
   Hepple, Roman Rudakov, Russell Sim, Ryan Phillips, Rytis Paškauskas,
   Rudolf Adamkovič, Sam Kleinman, Samuel Culpepper, Saša Janiška,
-  Shreyas Ragavan, Simon Pugnet, Steve Downey, Tassilo Horn, Thanos
-  Apollo, Thibaut Verron, Thomas Heartman, Togan Muftuoglu, Tony
-  Zorman, Trey Merkley, Tomasz Hołubowicz, Toon Claes, Uri Sharf,
-  Utkarsh Singh, Vincent Foley, Zoltan Kiraly. As well as users: Ben,
-  CsBigDataHub1, Emacs Contrib, Eugene, Fourchaux, Fredrik, Moesasji,
-  Nick, Summer Emacs, TheBlob42, TitusMu, Trey, bepolymathe,
-  bit9tream, bangedorrunt, case-lambda, chainedghost, derek-upham,
-  doolio, fleimgruber, gitrj95, iSeeU, jixiuf, ltmsyvag, okamsn,
-  pedro-nonfree, pRot0ta1p, shimeike, shipmints, soaringbird, tumashu,
-  wakamenod.
+  Shreyas Ragavan, Simon Pugnet, Stéphane Marks, Steve Downey, Tassilo
+  Horn, Thanos Apollo, Thibaut Verron, Thomas Heartman, Togan
+  Muftuoglu, Tony Zorman, Trey Merkley, Tomasz Hołubowicz, Toon Claes,
+  Uri Sharf, Utkarsh Singh, Vincent Foley, Zoltan Kiraly. As well as
+  users: Ben, CsBigDataHub1, Emacs Contrib, Eugene, Fourchaux,
+  Fredrik, Moesasji, Nick, Summer Emacs, TheBlob42, TitusMu, Trey,
+  bepolymathe, bit9tream, bangedorrunt, case-lambda, chainedghost,
+  derek-upham, doolio, fleimgruber, gitrj95, iSeeU, jixiuf, ltmsyvag,
+  okamsn, pedro-nonfree, pRot0ta1p, shimeike, shipmints, soaringbird,
+  tumashu, wakamenod.
 
 + Packaging :: Basil L.{{{space()}}} Contovounesios, Eli Zaretskii,
   Glenn Morris, Mauro Aranda, Richard Stallman, Stefan Kangas (core
diff --git a/modus-themes.el b/modus-themes.el
index bbd71521b0..3bcc190b17 100644
--- a/modus-themes.el
+++ b/modus-themes.el
@@ -5,7 +5,7 @@
 ;; Author: Protesilaos Stavrou <[email protected]>
 ;; Maintainer: Protesilaos Stavrou <[email protected]>
 ;; URL: https://github.com/protesilaos/modus-themes
-;; Version: 5.0.0
+;; Version: 5.1.0
 ;; Package-Requires: ((emacs "28.1"))
 ;; Keywords: faces, theme, accessibility
 

Reply via email to