branch: externals/logos
commit f372494ff0a87ab82bf09c661877a78109fc75ec
Author: Protesilaos Stavrou <[email protected]>
Commit: Protesilaos Stavrou <[email protected]>
Add some TODO to refine the code
I would like to work on them right now, but the laptop's battery is
running low. Hopefully tomorrow!
---
logos.el | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/logos.el b/logos.el
index d69d74c683..b02283a356 100644
--- a/logos.el
+++ b/logos.el
@@ -261,6 +261,8 @@ and disabled, then use the `logos-focus-mode-hook' instead."
Return `page-delimiter'."
(setq-local page-delimiter (if logos-outlines-are-pages
(logos--outline-regexp) logos-page-delimiter)))
+;; TODO 2025-11-26: I do not like this and wish to rewrite it. Though
+;; it technically works...
(defun logos--narrow-to-page (count &optional back)
"Narrow to COUNTth page with optional BACK motion."
;; Position point to avoid skipping pages.
@@ -296,12 +298,17 @@ Return `page-delimiter'."
"Hook that runs after a page motion.
See `logos-forward-page-dwim' or `logos-backward-page-dwim'.")
+;; TODO 2025-11-26: Refactor this to only accept a COUNT. We can
+;; infer BACK if COUNT is `minusp'.
(defun logos--page-motion (&optional count back)
"Routine for page motions.
With optional numeric COUNT move by that many pages. With
optional BACK perform the motion backwards."
(let ((cmd (if back #'backward-page #'forward-page)))
(logos-set-page-delimiter)
+ ;; TODO 2025-11-26: We would be skipping the current page
+ ;; delimiter if we are on its line. But check if this is releavnt
+ ;; when the buffer is narrowed.
(if (buffer-narrowed-p)
(logos--narrow-to-page count back)
(funcall cmd count)
