branch: externals/modus-themes
commit 5b4747748eed671fc3c36d61ecc11fcfba7995c0
Author: Protesilaos Stavrou <[email protected]>
Commit: Protesilaos Stavrou <[email protected]>

    Port emacs.git commit e09990891ffac9fa20385a8a38a18edf2e27d246
    
    This is done by Eshel Yaron, as discussed on the mailing list:
    <https://lists.gnu.org/archive/html/emacs-devel/2026-01/msg00011.html>.
---
 modus-themes.el | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/modus-themes.el b/modus-themes.el
index c01de48689..b7c3ce044a 100644
--- a/modus-themes.el
+++ b/modus-themes.el
@@ -4967,12 +4967,11 @@ If COLOR is unspecified, then return :box unspecified."
     `(compilation-warning ((,c :inherit modus-themes-bold :foreground 
,warning)))
 ;;;;; completion-preview
     `(completion-preview ((,c :foreground ,fg-dim)))
+    ;; We set the following faces to inherit from `completion-preview',
+    ;; as they do by default.  If we ever want them not to inherit from
+    ;; `completion-preview', then we should remember to customize
+    ;; `completion-preview-adapt-background-color' accordingly.
     `(completion-preview-common ((,c :inherit completion-preview :underline 
t)))
-    ;; NOTE 2025-11-18: We have to inherit `completion-preview'
-    ;; otherwise the `hl-line-mode' line loses its background where
-    ;; the `completion-preview-mode' overlay is.  This is not
-    ;; intuitive, given that we do not set a background for
-    ;; `completion-preview'.
     `(completion-preview-exact ((,c :inherit (modus-themes-completion-match-0 
completion-preview))))
 ;;;;; completions
     `(completions-annotations ((,c :inherit modus-themes-slant :foreground 
,docstring)))

Reply via email to