branch: externals/po-mode
commit bbb27572e03ab8a90fad3cc70f4c30b83a393d75
Author: Bruno Haible <[email protected]>
Commit: Bruno Haible <[email protected]>
Restore syntax highlighting in Emacs 30 or newer.
Reported by Sab Pyrope <[email protected]> in
<https://lists.gnu.org/archive/html/bug-gettext/2025-03/msg00017.html>
and by Julien Palard <[email protected]> in
<https://lists.gnu.org/archive/html/bug-gettext/2025-10/msg00000.html>.
It's a regression in Emacs 30, in commit
17e26cf57e18c5df2172a7049591d89fc53b3fb6 .
* gettext-tools/emacs/HACKING: Document how to bisect Emacs regressions.
* gettext-tools/emacs/po-mode.el (po-mode-version-string): Bump to 2.31.
(po-mode): Invoke run-mode-hooks instead of run-hooks.
* NEWS: Mention the fix.
---
HACKING | 37 +++++++++++++++++++++++++++++++++++++
po-mode.el | 4 ++--
2 files changed, 39 insertions(+), 2 deletions(-)
diff --git a/HACKING b/HACKING
index 8ee4330a5e..d02a3be7d8 100644
--- a/HACKING
+++ b/HACKING
@@ -1,3 +1,6 @@
+WARNING
+=======
+
This directory gets automatically mirrored at
https://github.com/emacsmirror/po-mode/
@@ -10,3 +13,37 @@ https://github.com/melpa/melpa/blob/master/README.md ):
(add-to-list 'package-archives '("melpa" . "https://melpa.org/packages/";))
Therefore, don't make untested changes in this directory!
+
+
+Testing
+=======
+
+Testing changes done in this directory:
+
+/some/bin/emacs -q -l `pwd`/start-po.el -l `pwd`/po-mode.el ~/clisp.de.po
+
+
+Fixing bugs due to regressions in Emacs
+=======================================
+
+* Look in the Emacs NEWS file.
+
+* Bisect from one release to the next. Example:
+
+version=20230801; git checkout deb8b933bce29f99c90f5f305d0d1b75c6d27527
OK
+<Add intermediate versions here.>
+version=20250223; git checkout 8334a9bd73f01a714ba352a49b1f040264ed4eac
KO
+
+Commands:
+
+- Build:
+./autogen.sh; mkdir bb$version; cd bb$version;
PKG_CONFIG_PATH=/arch/x86_64-linux-gnu/gnu/lib/pkgconfig ../configure
--host=x86_64-pc-linux-gnu
--prefix=/arch/x86_64-linux-gnu/gnu-inst-emacs-nox/$version CPPFLAGS=-Wall
--disable-silent-rules --without-x --without-toolkit-scroll-bars
--with-gif=ifavailable --with-gnutls=ifavailable && make && make install
+
+- Test that version:
+/arch/x86_64-linux-gnu/gnu-inst-emacs-nox/$version/bin/emacs -q -l
/GETTEXT/gettext/gettext-tools/emacs/start-po.el -l
/GETTEXT/gettext/gettext-tools/emacs/po-mode.el ~/clisp.de.po
+
+- Cleanup the build:
+cd ..
+rm -f build-aux/config.guess build-aux/config.sub build-aux/install-sh
exec/config.guess exec/config.h.in exec/config.sub exec/install-sh
lisp/loaddefs.el `find lisp -name '*.elc'`; git diff | patch -p1 -R
+
+- Select new version to test, and loop.
diff --git a/po-mode.el b/po-mode.el
index 2cde7af146..80fede9dd2 100644
--- a/po-mode.el
+++ b/po-mode.el
@@ -62,7 +62,7 @@
;;; Code:
-(defconst po-mode-version-string "2.30" "\
+(defconst po-mode-version-string "2.31" "\
Version number of this version of po-mode.el.")
;;; Emacs portability matters - part I.
@@ -1002,7 +1002,7 @@ all reachable through 'M-x customize', in group
'Emacs.Editing.I18n.Po'."
(add-hook 'write-contents-functions 'po-replace-revision-date)
- (run-hooks 'po-mode-hook)
+ (run-mode-hooks 'po-mode-hook)
(message (_"You may type 'h' or '?' for a short PO mode reminder.")))
(defvar po-subedit-mode-map
