branch: externals/popper
commit cfca7fde9e28320299b15ea573d5b556183aa34c
Author: Karthik Chikmagalur <[email protected]>
Commit: Karthik Chikmagalur <[email protected]>
popper: Toggle atomic window popups as a group
* popper.el (popper--delete-popup): Stop un-atomizing atomic
windows when closing popups. In retrospect this was not a good
idea. The idea was that it should be possible to have one buffer
in an atomic window group be a popup that can be toggled without
also deleting the other non-popup windows. But
- this breaks the atomic window contract without the user's
- permission, and
- the implementation breaks the group entirely and does not
restore it when the popup is displayed again.
Atomic window parameters are no longer touched by Popper. It is
no longer possible to have an atomic window group one of whose
windows shows a toggleable popup buffer, but Popper's behavior is
less presumptuous overall.
---
popper.el | 3 ---
1 file changed, 3 deletions(-)
diff --git a/popper.el b/popper.el
index 201a6cad3c..f92cbd3380 100644
--- a/popper.el
+++ b/popper.el
@@ -475,9 +475,6 @@ a popup buffer to open."
(when (window-valid-p win)
(cond
((window-parent win)
- ;; FIXME Possibly a bad idea to mess with atomic windows
- (when (window-parameter win 'window-atom)
- (set-window-parameter win 'window-atom nil))
;; Kludge. Side windows and regular windows are handled differently. The
;; latter is still somewhat broken. This is a bad idea.
(if (window-parameter win 'window-side)
