branch: externals/hyperbole
commit 97ebcb720734590c270802922898032735f316a5
Author: bw <[email protected]>
Commit: bw <[email protected]>
hywiki.el - Fix bug#80579 don't change completion-cycle-threshold
---
ChangeLog | 11 ++++++++++-
hywiki.el | 9 ++-------
2 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 5bffb9b228..9abd74230f 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2026-03-09 Bob Weiner <[email protected]>
+
+* hywiki.el (hywiki-word-add-completion-at-point):
+ (hywiki-word-remove-completion-at-point): Remove the setting and
+ unsetting of 'completion-cycle-threshold' to t. Will solve basic Emacs
+ completion with spaces another way that does not affect this basic Emacs
+ behavior. This fixes Emacs bug#80579: HyWiki globally overwrites
+ completion-cycle-threshold.
+
2026-03-08 Bob Weiner <[email protected]>
* hywiki.el (hywiki-get-buttonize-characters): Optimize this costly function
@@ -44,7 +53,7 @@
when using Emacs default completion.
(hywiki-word-add-completion-at-point): With default Emacs
completion,
add: (setq completion-cycle-threshold t)
- (hywiki-word-remove-completion-at-point): Restore customized setting of
+ (hywiki-word-remove-completion-at-point): Restore customized
setting of
'completion-cycle-threshold'.
* test/hywiki-tests.el (hywiki-tests--edit):
diff --git a/hywiki.el b/hywiki.el
index 2085091bab..653257f847 100644
--- a/hywiki.el
+++ b/hywiki.el
@@ -3,7 +3,7 @@
;; Author: Bob Weiner
;;
;; Orig-Date: 21-Apr-24 at 22:41:13
-;; Last-Mod: 8-Mar-26 at 23:29:50 by Bob Weiner
+;; Last-Mod: 9-Mar-26 at 23:30:49 by Bob Weiner
;;
;; SPDX-License-Identifier: GPL-3.0-or-later
;;
@@ -4066,11 +4066,7 @@ completion to work properly."
(add-hook 'company-completion-cancelled-hook
#'hywiki-completion-exit-function))
;; Default Emacs completion
- (t (advice-add 'completion--insert :after
#'hywiki-completion-exit-function)
- ;; Next setting is necessary to cycle through completions with
- ;; spaces in them within the buffer since Emacs does not by
- ;; default show completions with spaces in the *Completions* buffer.
- (setq completion-cycle-threshold t))))
+ (t (advice-add 'completion--insert :after
#'hywiki-completion-exit-function))))
(defun hywiki-word-remove-completion-at-point ()
"Remove HyWiki refs in-buffer completion from
`completion-at-point-functions'."
@@ -4079,7 +4075,6 @@ completion to work properly."
(remove-hook 'company-completion-cancelled-hook
#'hywiki-completion-exit-function)
(advice-remove 'completion--insert #'hywiki-completion-exit-function)
;; Restore user's customized setting of these options.
- (custom-reevaluate-setting 'completion-cycle-threshold)
(custom-reevaluate-setting 'tab-always-indent))
(defun hywiki-word-highlight-buffers (buffers)
