branch: externals/org
commit 3c8809b3dfcf328c8222917cd55b72a599722c14
Author: Slawomir Grochowski <[email protected]>
Commit: Slawomir Grochowski <[email protected]>
; org-colview: Remove redundant row preparation time binding
* lisp/org-colview.el (org-columns--prepare-rows): Remove redundant
`org-columns--time' binding. Keep summary time capture in
`org-columns-compute-all'.
The binding was introduced by ab4ae779f, which extracted
`org-columns--prepare-rows' from `org-columns'. It duplicates the
binding in `org-columns-compute-all', where summary time is captured
for actual summary computation.
Refactoring: Remove Dead Code.
No behavior change.
---
lisp/org-colview.el | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/lisp/org-colview.el b/lisp/org-colview.el
index 22f01a2d82..c07fc5073e 100644
--- a/lisp/org-colview.el
+++ b/lisp/org-colview.el
@@ -991,14 +991,13 @@ the buffer."
(move-marker org-columns-begin-marker (point))
(setq org-columns-begin-marker (point-marker)))
(org-columns-goto-top-level)
- (let ((org-columns--time (float-time)))
- (org-columns-get-format columns-format)
- (unless org-columns-inhibit-recalculation (org-columns-compute-all))
- (save-restriction
- (when (and (not global) (org-at-heading-p))
- (narrow-to-region (point) (org-end-of-subtree t t)))
- (org-columns--compute-clock-summaries)
- (org-columns--collect-rows))))
+ (org-columns-get-format columns-format)
+ (unless org-columns-inhibit-recalculation (org-columns-compute-all))
+ (save-restriction
+ (when (and (not global) (org-at-heading-p))
+ (narrow-to-region (point) (org-end-of-subtree t t)))
+ (org-columns--compute-clock-summaries)
+ (org-columns--collect-rows)))
;;;###autoload
(defun org-columns (&optional global columns-format)
