branch: externals/gnorb
commit 4e7039a15b47244e7bd2c580d8bce976a6116b5a
Author: Eric Abrahamsen <[email protected]>
Commit: Eric Abrahamsen <[email protected]>
Various compiler-inspired improvements
* gnorb-bbdb.el: Make sure external variables are defvar'd before we use
them.
* gnorb-gnus.el: Ditto.
* gnorb-org.el: Ditto.
---
gnorb-bbdb.el | 6 ++++--
gnorb-gnus.el | 6 +++++-
gnorb-org.el | 6 ++++++
3 files changed, 15 insertions(+), 3 deletions(-)
diff --git a/gnorb-bbdb.el b/gnorb-bbdb.el
index 2785e12..eb2f6eb 100644
--- a/gnorb-bbdb.el
+++ b/gnorb-bbdb.el
@@ -205,6 +205,8 @@ Org tags are stored in the `gnorb-bbdb-org-tags-field'."
(insert
(bbdb-indent-string (concat val "\n") indent)))))))
+(defvar message-mode-hook)
+
;;;###autoload
(defun gnorb-bbdb-mail (records &optional subject n verbose)
"\\<bbdb-mode-map>Acts just like `bbdb-mail', except runs
@@ -437,8 +439,8 @@ a prefix arg and \"*\", the prefix arg must come first."
mail-string)))
;;; Field containing links to recent messages
-
-(add-to-list 'bbdb-xfield-label-list gnorb-bbdb-messages-field nil 'eq)
+(when (boundp 'bbdb-xfield-label-list)
+ (add-to-list 'bbdb-xfield-label-list gnorb-bbdb-messages-field nil 'eq))
(defun gnorb-bbdb-display-messages (record format)
"Show links to the messages collected in the
diff --git a/gnorb-gnus.el b/gnorb-gnus.el
index 38c8d90..a77a7ed 100644
--- a/gnorb-gnus.el
+++ b/gnorb-gnus.el
@@ -195,7 +195,7 @@ save them into `gnorb-tmp-dir'."
(set-buffer (org-capture-get :original-buffer)))
(unless (memq major-mode '(gnus-summary-mode gnus-article-mode))
(error "Only works in Gnus summary or article buffers"))
- (let ((article (gnus-summary-article-number))
+ (let ((article (gnus-summary-article-number))
mime-handles)
(when (or (null gnus-current-article)
(null gnus-article-current)
@@ -239,6 +239,8 @@ save them into `gnorb-tmp-dir'."
(add-hook 'org-capture-mode-hook 'gnorb-gnus-capture-attach)
+(defvar org-note-abort)
+
(defun gnorb-gnus-capture-abort-cleanup ()
(with-no-warnings ; For `org-note-abort'
(when (and org-note-abort
@@ -438,6 +440,8 @@ work."
"Message will trigger TODO state-changes after sending"
"A TODO will be made from this message after it's sent"))))))
+(defvar org-capture-link-is-already-stored)
+
(defun gnorb-gnus-outgoing-make-todo-1 ()
(unless gnorb-gnus-new-todo-capture-key
(error "No capture template key set, customize
gnorb-gnus-new-todo-capture-key"))
diff --git a/gnorb-org.el b/gnorb-org.el
index e68fcff..d54e9ba 100644
--- a/gnorb-org.el
+++ b/gnorb-org.el
@@ -244,6 +244,8 @@ See the docstring of `gnorb-org-handle-mail' for details."
(msg-id-link
`(:gnus ,(list msg-id-link))))))
+(defvar message-beginning-of-line)
+
(defun gnorb-org-setup-message
(&optional messages mails from cc bcc attachments text ids)
"Common message setup routine for other gnorb-org commands.
@@ -340,6 +342,8 @@ current heading, or the heading indicated by optional
argument ID."
(org-attach-file-list attach-dir))))
files)))
+(defvar message-mode-hook)
+
;;;###autoload
(defun gnorb-org-handle-mail (&optional arg text file)
"Handle current headline as a mail TODO.
@@ -477,6 +481,8 @@ respective (usual) file extensions. Ugly way to do it, but
what
the hey..."
:group 'gnorb-org)
+(defvar org-export-show-temporary-export-buffer)
+
;;;###autoload
(defun gnorb-org-email-subtree (&optional arg)
"Call on a subtree to export it either to a text string or a file,
