branch: elpa/buttercup commit d6cf530e2cd05c9f6cddaa48df26d7c416e0eab3 Author: Jorgen Schaefer <cont...@jorgenschaefer.de> Commit: Jorgen Schaefer <cont...@jorgenschaefer.de>
Clean up the interactive reporter. Initialize the failed specs variable that is used later, do not fail in the read-only buffer, and use special-mode instead of view-mode. --- buttercup.el | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/buttercup.el b/buttercup.el index 4088eb2..6e0956e 100644 --- a/buttercup.el +++ b/buttercup.el @@ -762,7 +762,8 @@ Calls either `buttercup-reporter-batch' or (print-escape-nonascii t)) (pcase event (`buttercup-started - (setq buttercup-reporter-batch--start-time (float-time)) + (setq buttercup-reporter-batch--start-time (float-time) + buttercup-reporter-batch--failures nil) (buttercup--print "Running %s specs.\n\n" (buttercup-suites-total-specs-defined arg))) @@ -838,12 +839,13 @@ Calls either `buttercup-reporter-batch' or "Reporter for interactive uses." ;; This is a bit rudimentary ... (with-current-buffer (get-buffer-create "*Buttercup*") - (when (eq event 'buttercup-started) - (erase-buffer) - (view-mode 1) - (display-buffer (current-buffer))) (let ((old-print (symbol-function 'buttercup--print)) - (buf (current-buffer))) + (buf (current-buffer)) + (inhibit-read-only t)) + (when (eq event 'buttercup-started) + (erase-buffer) + (special-mode) + (display-buffer (current-buffer))) (fset 'buttercup--print (lambda (fmt &rest args) (with-current-buffer buf (let ((inhibit-read-only t))