branch: elpa/projectile
commit df3d73e1f0ff625a09196ff3ba6f4be82a53fb3b
Author: Bozhidar Batsov <bozhi...@batsov.dev>
Commit: Bozhidar Batsov <bozhi...@batsov.dev>
Move defvars out of eval-when-compile
`defvar` (when given a single argument) is a compiler directive whose
execution has no effect.
The fact that it also works when placed inside `eval-when-compile` is an
accident (and a bug: it should only affect the rest of the code within
the `eval-when-compile`).
---
projectile.el | 33 +++++++++++++++++----------------
1 file changed, 17 insertions(+), 16 deletions(-)
diff --git a/projectile.el b/projectile.el
index 89e1610e4b..cfe6a94142 100644
--- a/projectile.el
+++ b/projectile.el
@@ -47,17 +47,23 @@
(require 'find-dired)
(require 'subr-x))
-(eval-when-compile
- (defvar ido-mode)
- (defvar ivy-mode)
- (defvar helm-mode)
- (defvar ag-ignore-list)
- (defvar ggtags-completion-table)
- (defvar tags-completion-table)
- (defvar tags-loop-scan)
- (defvar tags-loop-operate)
- (defvar eshell-buffer-name)
- (defvar explicit-shell-file-name))
+;;; Declarations
+;;
+;; A bunch of variable and function declarations
+;; needed to appease the byte-compiler.
+(defvar ido-mode)
+(defvar ivy-mode)
+(defvar helm-mode)
+(defvar ag-ignore-list)
+(defvar ggtags-completion-table)
+(defvar tags-completion-table)
+(defvar tags-loop-scan)
+(defvar tags-loop-operate)
+(defvar eshell-buffer-name)
+(defvar explicit-shell-file-name)
+(defvar grep-files-aliases)
+(defvar grep-find-ignored-directories)
+(defvar grep-find-ignored-files)
(declare-function tags-completion-table "etags")
(declare-function make-term "term")
@@ -79,11 +85,6 @@
(declare-function vterm "ext:vterm")
(declare-function vterm-send-return "ext:vterm")
(declare-function vterm-send-string "ext:vterm")
-
-(defvar grep-files-aliases)
-(defvar grep-find-ignored-directories)
-(defvar grep-find-ignored-files)
-
;;; Customization
(defgroup projectile nil
