branch: elpa/cider
commit 3972347a5d4083f09f7bf8cc78adff2055cda768
Author: chaos <chaos@sympan>
Commit: Bozhidar Batsov <bozhi...@batsov.dev>
Fix unused returned value compilation warning
and mark unused params with _
---
cider-browse-ns.el | 2 +-
cider-classpath.el | 2 +-
cider-repl-history.el | 4 ++--
cider-util.el | 5 ++---
4 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/cider-browse-ns.el b/cider-browse-ns.el
index 6cb2f61e19..5b6f261287 100644
--- a/cider-browse-ns.el
+++ b/cider-browse-ns.el
@@ -223,7 +223,7 @@ be displayed."
(cider-find-ns nil value)
(cider-find-var current-prefix-arg value))))
-(defun cider-browse-ns-handle-mouse (event) ;FIXME: Unused arg!
+(defun cider-browse-ns-handle-mouse (_event) ;FIXME: Unused arg!
"Handle mouse click EVENT."
(interactive "e")
(cider-browse-ns-operate-at-point))
diff --git a/cider-classpath.el b/cider-classpath.el
index e4d4ba5533..6e457f513c 100644
--- a/cider-classpath.el
+++ b/cider-classpath.el
@@ -80,7 +80,7 @@
(line (buffer-substring-no-properties bol eol)))
(find-file-other-window line)))
-(defun cider-classpath-handle-mouse (event) ;FIXME: Unused arg!
+(defun cider-classpath-handle-mouse (_event) ;FIXME: Unused arg!
"Handle mouse click EVENT."
(interactive "e")
(cider-classpath-operate-on-point))
diff --git a/cider-repl-history.el b/cider-repl-history.el
index 4a4c7c87c6..c5e9819c77 100644
--- a/cider-repl-history.el
+++ b/cider-repl-history.el
@@ -330,7 +330,7 @@ it's turned on."
before-insert
(point))))
-(defun cider-repl-history-target-overlay-at (position &optional no-error)
+(defun cider-repl-history-target-overlay-at (_position &optional no-error)
"Return overlay at POSITION that has property `cider-repl-history-target'.
If no such overlay, raise an error unless NO-ERROR is true, in which
case return nil."
@@ -352,7 +352,7 @@ Might error unless NO-ERROR set."
(unless no-error
(error "No CIDER history item in this buffer")))))
-(defun cider-repl-history-do-insert (buf pt)
+(defun cider-repl-history-do-insert (_buf pt)
"Helper function to insert text from BUF at PT into the REPL buffer.
Also kills *cider-repl-history*."
;; Note: as mentioned at the top, this file is based on browse-kill-ring,
diff --git a/cider-util.el b/cider-util.el
index c35f925975..bc73930179 100644
--- a/cider-util.el
+++ b/cider-util.el
@@ -377,9 +377,8 @@ propertized (defaults to current buffer)."
(defun cider--pkg-version ()
"Extract CIDER's package version from its package metadata."
;; FIXME: Inline the logic from package-get-version and adapt it
- (if (fboundp 'package-get-version)
- (package-get-version)
- nil))
+ (cond ((fboundp 'package-get-version)
+ (package-get-version))))
(defun cider--version ()
"Retrieve CIDER's version.
