branch: elpa/subed
commit 6591e1d49126dde225ae14b6dffefa905c98cc8d
Author: Sacha Chua <sa...@sachachua.com>
Commit: Sacha Chua <sa...@sachachua.com>
Add comment tests and bump version
* tests/test-subed-srt.el ("SRT"): Add comment tests.
* subed/subed.el: Increase version.
* NEWS.org (Version 1.0.8 - 2022-09-08 - Sacha Chua): Document change.
---
NEWS.org | 5 +++++
subed/subed.el | 2 +-
tests/test-subed-srt.el | 16 +++++++++++++++-
3 files changed, 21 insertions(+), 2 deletions(-)
diff --git a/NEWS.org b/NEWS.org
index eb8d300085..bd46233480 100644
--- a/NEWS.org
+++ b/NEWS.org
@@ -1,4 +1,9 @@
* subed news
+** Version 1.0.8 - 2022-09-08 - Sacha Chua
+
+- Added support for SRT comment syntax thanks to mbork.
+ http://mbork.pl/2022-09-05_Comments_in_srt_files
+
** Version 1.0.6 - 2022-07-22 - Sacha Chua
- Allow mm:ss.000 (optional hours) when validating VTT files.
diff --git a/subed/subed.el b/subed/subed.el
index 4b7ad1d11c..06b18ced70 100644
--- a/subed/subed.el
+++ b/subed/subed.el
@@ -1,6 +1,6 @@
;;; subed.el --- A major mode for editing subtitles -*- lexical-binding: t;
-*-
-;; Version: 1.0.7
+;; Version: 1.0.8
;; Maintainer: Sacha Chua <sa...@sachachua.com>
;; Author: Random User
;; Keywords: convenience, files, hypermedia, multimedia
diff --git a/tests/test-subed-srt.el b/tests/test-subed-srt.el
index 553b122b7d..bfad61c461 100644
--- a/tests/test-subed-srt.el
+++ b/tests/test-subed-srt.el
@@ -1525,4 +1525,18 @@ Baz.
(subed-merge-with-next)
(expect (subed-subtitle-text) :to-equal "Bar.\nBaz.")
(expect (subed-subtitle-msecs-start) :to-equal 122234)
- (expect (subed-subtitle-msecs-stop) :to-equal 195500)))))
+ (expect (subed-subtitle-msecs-stop) :to-equal 195500))))
+
+ (describe "A comment"
+ (it "is validated."
+ (with-temp-srt-buffer
+ (insert mock-srt-data "\n\n4\n00:04:00,000 --> 00:05:00,000\n{\\This is
a comment} Hello\n")
+ (subed-validate)
+ (expect (point) :to-equal (point-max))))
+ (it "is highlighted as a comment."
+ (with-temp-srt-buffer
+ (insert mock-srt-data "\n\n4\n00:04:00,000 --> 00:05:00,000\n{\\This is
a comment} Hello\n")
+ (re-search-backward "comment")
+ (expect (nth 4 (syntax-ppss)) :to-be t)
+ (re-search-forward "Hello")
+ (expect (nth 4 (syntax-ppss)) :to-be nil)))))
