branch: elpa/auto-dim-other-buffers
commit b599ff6db975d3506e921095b679d869edaaf0e7
Author: Michal Nazarewicz <min...@mina86.com>
Commit: Michal Nazarewicz <min...@mina86.com>
Better clean up when disabling the mode; remove arg from dim-all-buffers
In addition to undimming all buffers when mode is disabled, kill all
buffer-local definitions of ‘adob--face-mode-remapping’ variable. It’s
admittedly not a big issue but it leaves things cleaner.
With that change, remove argument from ‘adob--dim-all-buffers’ since
it’s no longer ever used for undimming.
---
auto-dim-other-buffers.el | 22 ++++++++++++++--------
1 file changed, 14 insertions(+), 8 deletions(-)
diff --git a/auto-dim-other-buffers.el b/auto-dim-other-buffers.el
index 44e860c892..a5fad9076a 100644
--- a/auto-dim-other-buffers.el
+++ b/auto-dim-other-buffers.el
@@ -8,7 +8,7 @@
;; Michal Nazarewicz <min...@mina86.com>
;; Maintainer: Michal Nazarewicz <min...@mina86.com>
;; URL: https://github.com/mina86/auto-dim-other-buffers.el
-;; Version: 1.8
+;; Version: 1.8.1
;; This file is not part of GNU Emacs.
@@ -118,7 +118,7 @@ Currently only mini buffer and echo areas are ignored."
(defun adob--focus-out-hook ()
"Dim all buffers if `auto-dim-other-buffers-dim-on-focus-out'."
(when auto-dim-other-buffers-dim-on-focus-out
- (adob--dim-all-buffers t)))
+ (adob--dim-all-buffers)))
(defun adob--focus-in-hook ()
"Undim current buffers if `auto-dim-other-buffers-dim-on-focus-out'."
@@ -126,15 +126,15 @@ Currently only mini buffer and echo areas are ignored."
(adob--undim-buffer)
(setq adob--last-buffer (current-buffer))))
-(defun adob--dim-all-buffers (dim)
- "Dim (if DIM is non-nil) or undim all buffers which are not to be ignored.
+(defun adob--dim-all-buffers ()
+ "Dim all buffers which are not to be ignored.
Whether buffer should be ignored is determined by `adob--never-dim-p'
function."
(save-current-buffer
(dolist (buffer (buffer-list))
(unless (adob--never-dim-p buffer)
(set-buffer buffer)
- (if dim (adob--dim-buffer) (adob--undim-buffer))))))
+ (adob--dim-buffer)))))
(defun adob--hooks (callback)
"Add (if CALLBACK is `add-hook') or remove (if `remove-hook') adob hooks."
@@ -149,13 +149,19 @@ function."
"Visually makes non-current buffers less prominent"
:lighter " Dim"
:global t
+ (setq adob--last-buffer nil)
(if auto-dim-other-buffers-mode
(progn
- (setq adob--last-buffer nil)
- (adob--dim-all-buffers t)
+ (adob--dim-all-buffers)
(adob--hooks 'add-hook))
(adob--hooks 'remove-hook)
- (adob--dim-all-buffers nil)))
+ (save-current-buffer
+ (dolist (buffer (buffer-list))
+ (when (local-variable-p 'adob--face-mode-remapping buffer)
+ (set-buffer buffer)
+ (when adob--face-mode-remapping
+ (face-remap-remove-relative adob--face-mode-remapping))
+ (kill-local-variable 'adob--face-mode-remapping))))))
(provide 'auto-dim-other-buffers)
