stardiviner <numbch...@gmail.com> writes: > I hope to merge this patch to Org-mode `ob-lisp.el`. >
I have only looked at the surface of it, but I see some issues. > < ;; Copyright (C) 2016-2020 Free Software Foundation, Inc. > --- > > ;; Copyright (C) 2009-2016 Free Software Foundation, Inc. Why did you leave out the previous copyright statement? Where did 2020 come from? > < ;; Authors: stardiviner <numbch...@gmail.com> > < ;; Maintainer: stardiviner <numbch...@gmail.com> > < ;; Keywords: org babel lisp sly slime > < ;; URL: https://github.com/stardiviner/ob-lisp > < ;; Created: 1th March 2016 > < ;; Version: 0.0.1 > < ;; Package-Requires: ((org "8")) > --- >> ;; Authors: Joel Boehland >> ;; Eric Schulte >> ;; David T. O'Toole <d...@gnu.org> >> ;; Keywords: literate programming, reproducible research >> ;; Homepage: http://orgmode.org Why did you erase the previous authors? Are you volunteering to be the maintainer of ob-lisp.el or are you planning to keep your own repo and submit patches? Have you signed FSF papers? > < ;; Requires SLY (Sylvester the Cat's Common Lisp IDE) and SLIME > < ;; See: > < ;; - https://github.com/capitaomorte/sly > < ;; - http://common-lisp.net/project/slime/ > --- >> ;; Requires SLIME (Superior Lisp Interaction Mode for Emacs.) >> ;; See http://common-lisp.net/project/slime/ Does it really require both? If so, I suggest you rework it so either can be used, but only one is required. If not, I suggest you fix the comment. -- Nick