Hi Nicolas, So I will:
- add "org-babel-sql-convert-filename", so another name...I am thinking - remove `msosql` support. I am been playing with the options for a while, and I could not find a way the make osql output the same format as sqlcmd Thanks, David On Sun, Jun 12, 2016 at 10:12 AM Xi Shen <davidshe...@gmail.com> wrote: > Yes, I think it is better to let upstream function to resolve the path for > org-mode. > > But I have never contacted Emacs developers before. Should I go through > the bug-gnu-em...@gnu.org mail list? Or there's a more effective channel? > > > On Sat, Jun 11, 2016 at 4:41 PM Nicolas Goaziou <m...@nicolasgoaziou.fr> > wrote: > >> Hello, >> >> Xi Shen <davidshe...@gmail.com> writes: >> >> > According to >> > >> https://www.gnu.org/software/emacs/manual/html_node/elisp/Standard-File-Names.html >> , >> > the `convert-standard-filename` works for *nix and MS-DOS, but not >> Cygwin >> > environment. And I tested, it does not work. For the prefix, please >> advice >> > me a better one. Maybe we should path this function first? How can I >> > patch/update a Emacs native function? >> >> Since there is no module in Emacs, you need to prefix functions and >> variables according to the package, or, even better, the library they >> belong to. >> >> Hence, functions and variables in "ob-sql.el" are prefixed with >> "org-babel-sql-". >> >> Do you mind discussing it upstream on emacs-devel ML first? I don't >> think this kind of function belongs to Org. If upstream has no >> equivalent and doesn't want to add one, we might consider adding it to >> the library. >> >> WDYT? >> >> >> > The `osql` command line tool was last updated in 2004, >> >> > https://technet.microsoft.com/en-us/library/aa214012(v=sql.80).aspx, >> >> > and could not output the query result in a way that morden >> >> > `org-table.el` expects. The `sqlcmd` is the preferred command line >> >> > tool to connect the Microsoft SQL Server and it also has a Linux >> >> > version, >> >> > https://msdn.microsoft.com/en-us/library/hh568447(v=sql.110).aspx. >> >> >> >> Would it make sense to remove the msosql support then? >> >> >> > Yes, but I am also thinking about backward compatibility. Do you want >> > me to create a patch to remove `msosql` support? >> >> AFAIU, according to your comment, "osql" output is barely usable. If you >> think it is still usable and even used by some users, then I do not mind >> keeping it. I just wanted to be sure we're not keeping something that is >> not reasonable to keep. >> >> >> #'identity >> >> >> >> >> >>> OK, but what's the difference? Care to give me a short lesson? >> >>>Thanks! >> >> Not much difference, hence the "nitpick" tag. >> >> 'identity is a generic symbol, #'identity clearly indicates we (the >> user, the compiler) are interested in the symbol function cell. >> >> In this case, it is obvious, but it is not always the case in other >> parts of the code base, and more consistency in the right direction >> doesn't hurt. >> >> >> Regards, >> >> -- >> Nicolas Goaziou >> >> > > Thanks, > David > > -- > > Thanks, > David S. > -- Thanks, David S.
