Thanks Nicolas. I went ahead and set up a public branch for these changes.
I added ORG-NEWS entry, and some other minor changes in the commentary of ob-sql.el. https://github.com/madhat2r/org-mode/tree/feature/babel-sqsh-engine -Micah On Dec 03 at 09:08 AM, Nicolas Goaziou said thus: > Hello, > > MaDhAt2r <madha...@dukefoo.com> writes: > >> Thanks for your comments Nicolas! I hope this is better. > > Thank you. This looks good. > > However, I'm not able to apply it on master branch. Could you rebase > your branch against master and send that patch again? > > Also, could you provide an ORG-NEWS entry about the new feature? > >> +(defun org-babel-sql-dbstring-sqsh (host user password database) >> + "Make sqlcmd commmand line args for database connection. >> +`sqsh' is one method to access Sybase or MS SQL via Linux platform" > > `sqsh' -> "sqsh" > >> + (cond >> + ((equal (intern engine) 'sqsh) >> + (org-table-import out-file '(4)) >> + ) > > The lonesome parenthesis should go to the line above it. > > > Regards, > > -- > Nicolas Goaziou