Hello,
Adrian Bradd <adrian.br...@gmail.com> writes:
> Adds multi-file TRIGGER and BLOCKER tasks to org-depend by first searching
> the current file `org-find-entry-with-id` and then all files visisble
> through `org-find-id`.
> From d4095a57f1c9c42426d8c0d51ca7f4640f036a3a Mon Sep 17 00:00:00 2001
> From: Adrian Bradd <adrian.br...@gmail.com>
> Date: Thu, 13 Jul 2017 22:49:26 -0400
> Subject: [PATCH] org-depend: multi-file TRIGGER and BLOCKER tasks
Thank you.
You need to list the functions modified in the commit message:
lisp/contrib/org-depend.el (...function...): ....
> (catch 'return
> (unless (eq type 'todo-state-change)
> ;; We are only handling todo-state-change....
> @@ -336,11 +336,18 @@ This does two different kinds of triggers:
> (setq id (match-string 1 tr)
> kwd (match-string 2 tr)
> p1 (org-find-entry-with-id id))
> - (when p1
> + ;; first check current buffer, then all files
> + (if p1
> ;; there is an entry with this ID, mark it TODO
> (save-excursion
> (goto-char p1)
> - (org-todo kwd))))
> + (org-todo kwd))
> + (when (setq p2 (org-id-find id))
> + (save-excursion
> + (save-window-excursion
> + (find-file (car p2))
I suggest to use
(with-current-buffer (find-file-noselect (car p2))
...)
Then, `save-window-excursion' is not necessary.
> + ((setq p2 (org-id-find bl))
> + (save-excursion
> + (save-window-excursion
> + (find-file (car p2))
Ditto.
Regards,
--
Nicolas Goaziou
