Thanks, your new patch looks acceptable to me.
On Fri, Feb 9, 2018 at 7:02 AM Matt Lundin <m...@imapmail.org> wrote: > Allen Li <vianchielfa...@gmail.com> writes: > > > On Wed, Feb 7, 2018 at 1:47 PM Matt Lundin <m...@imapmail.org> wrote: > > > >> Matt Lundin <m...@imapmail.org> writes: > > > >> > I discovered that when trying to insert a new item with a checkbox > using > >> > M-S Return (org-insert-todo-heading), the keybinding is "translated" > to > >> > M-Return (org-meta-return). As a result, all I get is simple list item > >> > without a checkbox. > >> > > > > >> The attached patch fixes this issue. > > > > I'm pretty sure your patch would break those binding in terminal Emacs > > completely, since <return> cannot be typed in the terminal and Emacs > > does not remap these bindings. > > Attached please find a more limited patch that fixes the issue in the > GUI without affecting TTY use. I have only changed bindings for the > M-S-RET or S-RET combinations. These combinations cannot be used in the > TTY anyway and Org Mode already defines alternative TTY bindings for > these combinations. > > Best, > Matt > >