Hello org's developers,

I'm trying to correct the package `org-alert'
(https://github.com/spegoraro/org-alert) in order to not interfer with
the org-agenda buffer.

I've tried to call `org-agenda-list' inside a temp buffer. This could
work but the call to `recenter' throw an error which defeat the purpose
of temp buffer.

So could it be possible to apply the attached patch inside the
maintenance branch ? I see the unconditionnal call to `recenter' more as
an bug than a feature.

If it's not possible / desirable. Is there any function to achieve the
following goal : list the next scheduled / dead-lined events of today ?

>From 664b3d560f6d4caa00500add879923945453b7a7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pierre=20T=C3=A9choueyres?= <pierre.techouey...@free.fr>
Date: Wed, 28 Mar 2018 01:35:22 +0200
Subject: [PATCH] org-agenda.el Call `recenter' only if buffer has a window.

* lisp/org-agenda.el (org-agenda-list): Condition the call to
  `recenter` only when the buffer has a window associated.

This permit to call `org-agenda-list` in a `with-temp-buffer` like
below:

(with-temp-buffer
  (let ((org-agenda-sticky nil)
        (org-agenda-buffer-tmp-name (buffer-name)))
    (org-agenda-list 1)
    (buffer-string))
---
 lisp/org-agenda.el | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 649f5e2aa..cfe844536 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -4274,14 +4274,15 @@ items if they have an hour specification like [h]h:mm."
 	  (insert tbl)))
       (goto-char (point-min))
       (or org-agenda-multi (org-agenda-fit-window-to-buffer))
-      (unless (and (pos-visible-in-window-p (point-min))
+      (when (get-buffer-window)
+	(unless (and (pos-visible-in-window-p (point-min))
 		   (pos-visible-in-window-p (point-max)))
 	(goto-char (1- (point-max)))
 	(recenter -1)
 	(if (not (pos-visible-in-window-p (or start-pos 1)))
 	    (progn
 	      (goto-char (or start-pos 1))
-	      (recenter 1))))
+	      (recenter 1)))))
       (goto-char (or start-pos 1))
       (add-text-properties (point-min) (point-max)
 			   `(org-agenda-type agenda
-- 
2.14.3

Reply via email to