Hello, John Lee <j...@pobox.com> writes:
> Hi, sorry Nicolas I totally missed your review comments! No problem. > Trying hard to make up a reason for utility of the current behaviour: > let's say your habits tend to be weekly and have an optimum time and > weekday, but if you miss them it's just "as soon as possible". But if > anybody actually does see their habits that way, that would seem > likely to vary by habit. So I'd be surprised if the current behaviour > was very useful. > > Shall I make it the default, then? I think so. > Thank you. Right now I have one other change I'd like to submit which > is also tiny, do I need to start the assignment process? If both changes do not add up to around 15 non-trivial locs, that's fine. >> > +(defcustom org-habit-scheduled-past-days nil >> > + "Non-nil means the value of this variable will be used instead >> > +of org-scheduled-past-days, for habits only. >> >> First line needs to be a full sentence. Also, > > To me it looks like a full sentence? What I meant is the first line should contain only full sentences. Yours spans over two lines. > Should it be something like this below (based on looking at other docstrings)? > > "Value to use instead of `org-scheduled-past-days', for habits only. > > If nil, `org-scheduled-past-days' is used." That's better, indeed. > I think "as a mean of" is not correct English (I'm a native speaker in > the UK). Of course, you're right. Sorry for the noise. > Presumably I should use the version from the highest current git tag "plus > one", i.e. 9.3? > > :package-version '(Org . "9.3") That's correct. Regards, -- Nicolas Goaziou
