Nicolas Goaziou <m...@nicolasgoaziou.fr> writes: >> Any hope of this super tiny patch being applied? It addresses the >> problem I brought up in another thread: it is currently not possible >> to pass command line arguments to a java program. > > Org 9.3 is feature frozen for the time being. Do you think this > qualifies as a bugfix or as a new feature?
More of a new feature, I guess. > In the latter case, could you rebase it on top of "next" branch and > add an entry in ORG-NEWS, under "Org 9.4" section? I did my best; see attachments. There was no 9.4 section in ORG-NEWS, so I added my entry under "Version Next". Are these ok? Jarmo
>From 5089053f4f3f916dfbdab009d28b16ffac6f9055 Mon Sep 17 00:00:00 2001 From: Jarmo Hurri <jarmo.hu...@iki.fi> Date: Wed, 6 Nov 2019 12:21:16 +0200 Subject: [PATCH 1/2] ob-java.el: Add header argument to pass command line args. * lisp/ob-java.el (org-babel-execute:java): Handle new header argument `:cmdargs` and pass its value as the last element in call to java. --- lisp/ob-java.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/ob-java.el b/lisp/ob-java.el index b055f85e5..80308ec32 100644 --- a/lisp/ob-java.el +++ b/lisp/ob-java.el @@ -58,6 +58,7 @@ parameters may be used, like javac -verbose" (src-file (concat classname ".java")) (cmpflag (or (cdr (assq :cmpflag params)) "")) (cmdline (or (cdr (assq :cmdline params)) "")) + (cmdargs (or (cdr (assq :cmdargs params)) "")) (full-body (org-babel-expand-body:generic body params))) (with-temp-file src-file (insert full-body)) (org-babel-eval @@ -66,7 +67,7 @@ parameters may be used, like javac -verbose" (unless (or (not packagename) (file-exists-p packagename)) (make-directory packagename 'parents)) (let ((results (org-babel-eval (concat org-babel-java-command - " " cmdline " " classname) ""))) + " " cmdline " " classname " " cmdargs) ""))) (org-babel-reassemble-table (org-babel-result-cond (cdr (assq :result-params params)) (org-babel-read results) -- 2.21.0
>From 033f455399d0821d818ef6ff1c01036c04873ddb Mon Sep 17 00:00:00 2001 From: Jarmo Hurri <jarmo.hu...@iki.fi> Date: Sun, 1 Dec 2019 12:26:55 +0200 Subject: [PATCH 2/2] Mention header argument to pass command arguments to Java blocks in ORG-NEWS * etc/ORG-NEWS: Mention header argument :cmdargs for Java code blocks. --- etc/ORG-NEWS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/etc/ORG-NEWS b/etc/ORG-NEWS index 689a07871..ac3d1517f 100644 --- a/etc/ORG-NEWS +++ b/etc/ORG-NEWS @@ -19,6 +19,9 @@ just as if it was at outline level 0. Inheritance for properties will work also for this level. In other words; defining things in a property drawer before the first headline will make them "inheritable" for all headlines. +*** New header argument to pass Java command line arguments +Babel Java blocks recognize header argument =:cmdargs= and pass its +value in call to =java=. * Version 9.3 -- 2.21.0