Hi Kevin, this looks good. The patch is significant enough that we need you to sign the FSF copyright assignment papers. Here is the form:
https://code.orgmode.org/bzg/org-mode/raw/master/request-assign-future.txt Once you're done with this, we can push your commit. Should you contribute more, we can give you push access. Some comments below: Foley <ke...@kevinjfoley.me> writes: > This patch fixes the way `org-babel-detangle' handles false positive > matches for links. Without the patch it tries to use match data that > may not be present in a false positive. I've also included a regression > test. > > This is my first contribution to Org Mode or Emacs and my first patch > by mailing list so please let me know if I've overlooked anything. > > Also note I have not assigned copyright to FSF at this time, however I > believe this change should be small enough to not require it. > > Kevin Foley > > From 82e2d108536101c5a5ff9f8a0009051e5a308a3a Mon Sep 17 00:00:00 2001 > From: "Kevin J. Foley" <ke...@kevinjfoley.me> > Date: Tue, 28 Jan 2020 17:51:29 -0500 > Subject: [PATCH] Fix `org-babel-detangle' handling of false positives > > * lisp/ob-tangle.el (org-babel-detangle): Handle false positive > matches of `org-link-bracket-re' ^ There should be a "." at the end of sentences in changelog entries. > * testing/examples/babel.el: New file for babel detangle false > positive test ^ Same here. > * testing/examples/babel.org (detangle): Add detangle/false positive > example ^ And here. > * testing/lisp/test-ob-tangle.el (ob-tangle/detangle-false-positive): > Add test for detangle false positive ^ And here. > TINYCHANGE Well, there are more than 15 lines of changes. Signing the FSF papers will allow you to submit more changes later. Thanks! -- Bastien
