-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256
Jack Kamm <jackk...@gmail.com> writes: > Hi stardiviner, > > "numbch...@gmail.com" <numbch...@gmail.com> writes: > >> Yes, Jack, as Bastien said, you can format my commit, because my home >> network is broken, I'm using Mobile Phone's 4G network to get online. Can't >> get update immediately. > > OK, I've edited the commit message of your patch, and I also fixed the > compilation warning by updating the signature of "(declare-function > py-shell)". > > Commit has now been pushed to master :) > >> And thanks for tips about `python-mode' is deprecated. I didn't know that. >> I will migrate to `python.el'. > > Since python.el is built-in to Emacs, I think that things should > continue to work for python-mode.el users, even if we entirely switch > over to only using python.el. > > The only thing I'm not sure about, is whether the equivalent of > "python-shell-send-region" in python-mode.el will work with shells > started by python.el. If not, this could probably be addressed with a > patch to python-mode.el. > > You could test this by explicitly setting `org-babel-python-mode' to > `python' (it is probably set to `python-mode' on your system, which is > the default when python-mode.el is detected). > > I'll add a TODO for myself to explicitly mark python-mode-related > variables as deprecated. I'm also planning a major update to the Worg > documentation of ob-python when 9.4 comes out, and will mention the > deprecation there as well. Thanks for your work! Jack - -- [ stardiviner ] I try to make every word tell the meaning what I want to express. Blog: https://stardiviner.github.io/ IRC(freenode): stardiviner, Matrix: stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3 -----BEGIN PGP SIGNATURE----- iQFIBAEBCAAyFiEE8J9lDX1nSBmJJZFAG13xyVromsMFAl5OHPIUHG51bWJjaGls ZEBnbWFpbC5jb20ACgkQG13xyVromsMoIAgAupUPheHI9UoqcB7MIAH6qOZoZKfi A7WurI++ioXEUN6rBlGkv/cNA2WsOm7TIjfLq1uXIEHvfgLY4nM+0YQJmPX1XzGr ej+xNO+9sjwrXA83XELM5DcGhat2C3PBE0ANqZIeZxnE1roUOcYVCdIdrPsvrpWC /nSHIEB3fg19lq+QGwr17qXqLsNy/BjytixWclHQz9bmA5Cs9p9jGPDIamrEK+4w 7/1QMXg1B3GUPWrRLUfeMV3hye+btpPZOqVpk1OwVg0AJpp4brI/OvkzOrfDMhA4 fxjB/JE2Ll4hvN+MSJ0wGohMUIvClm9Li6jWsKmC1ZHtAdzn5lkKQ2nspA== =VCww -----END PGP SIGNATURE-----