Hello,
Brian Powell <powe...@hawaii.edu> writes:
> Nicolas, thank you for the feedback, and I apologize for my errors.
No need to apologize! Peer review is about catching the mistakes we all
do.
> I have corrected the issues below and generated a commit patch attached.
> Please let me know if there are any problems.
Thank you! I have some more work for you, if you don't mind ;)
> Subject: [PATCH] add org-html-equation-reference-format to customize MathJax
> ref command
The commit message should reference the file being modified. I suggest
something along the lines:
Add customizable format string for equations
* lisp/ox-html.el (org-html-equation-reference-format): New variable.
> +(defcustom org-html-equation-reference-format "\\eqref{%s}"
> + "MathJax command to use when referencing equations. This is a
> +format controls string, expecting a single argument, the equation
> +being referenced that is generated on export.
Small nit here. The first line of a docstring must contain complete
sentences only. Therefore you need to move "This is a" part to the line
below.
Also : controls -> control
Otherwise, it looks good! Could you provide an entry in ORG-NEWS about
it? I think Version 9.4 > Miscellaneous is a fine place for it.
Regards,
--
Nicolas Goaziou
