Hi, Nicolas, gentle ping about this patch. [stardiviner] <Hack this world!> GPG key ID: 47C32433 IRC(freeenode): stardiviner Twitter: @numbchild Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433 Blog: http://stardiviner.github.io/
On Mon, Aug 17, 2020 at 11:22 AM numbch...@gmail.com <numbch...@gmail.com> wrote: > Thanks for reviewing my code and points. :) > Fixed in this attached patch. > > [stardiviner] <Hack this world!> GPG key ID: 47C32433 > IRC(freeenode): stardiviner Twitter: @numbchild > Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433 > Blog: http://stardiviner.github.io/ > > > On Sun, Aug 16, 2020 at 5:54 PM Nicolas Goaziou <m...@nicolasgoaziou.fr> > wrote: > >> Hello, >> >> "numbch...@gmail.com" <numbch...@gmail.com> writes: >> >> > With this patch, ol-man.el link type can be a link like this: >> > ```org >> > [[man:grep::--extended-regexp][grep --extended-regexp]] >> > ``` >> > Occur will auto search "--extended-regexp" string in man page buffer. >> >> Thanks. >> >> > +PATH should be a topic that can be thrown at the man command. >> > +If PATH contains extra ::STRING which will use `occur' to search >> > +matched strings in man buffer." >> >> > + (string-match "\\(.*?\\)\\(?:::\\(.*\\)\\)?$" path) >> > + (let* ((command (match-string 1 path)) >> > + (search (match-string 2 path))) >> > + (funcall org-man-command command) >> > + (with-current-buffer (concat "*Man " command "*") >> >> This should only be called if search is non-empty. >> >> > + (occur search)))) >> >> Why occur? Org uses `search-forward' for [[foo.org::text]] text links, >> and uses `occur' with [[foo.org::/text/]] links. >> >> Wouldn't it be more idiomatic to use a regular text search here? >> >> Regards, >> -- >> Nicolas Goaziou >> >
