Hello, Timothy <tecos...@gmail.com> writes:
> Thanks for sending in the patch. Seeing it pointed out, this seems like > a pretty obvious omission. This looks like it should be pretty easy to > merge :) > > Four minor niggles with your commit message: > + Since `defvar' and `defcustom' are elisp symbols, they should be > quoted as such. > + It's probably better to avoid shorthand like "X -> Y", and write out > "Change X to Y" instead. > + You have included "lisp/" in the commit subject, which isn't needed. > Just "ob-fortran.el" or even "ob-fortran" is enough here. > + Your commit subject goes over 50 chars, which is undesirable. > > Here's what I'd recommend: > > #+begin_example > ob-fortran: Use a defcustom for fortran compiler > > * lisp/ob-fortran.el (org-babel-fortran-compiler): Change `defvar' to > `defcustom' > so that the fortran compiler is customizable like almost all other org-babel > compilers. > #+end_example > > This is rather minor though, I mention this mostly as a note for the > future :) Thanks. I went ahead, applied the patch with your recommendation, added a :package-version keyword, and pushed. Thanks. Regards, -- Nicolas Goaziou
