Hello, Maxim Nikulin <maniku...@gmail.com> writes:
> I think citation support is a great feature. (Sorry, I do not work > with references now, so I can tell nothing concerning implementation > for org.) > > It seems, rx e.g. in emacs-26.3 does not support all features used in > oc.el and oc-csl.el. Loading an org file using git master, I get > a warning > >> Eager macro-expansion failure: (error "rx form ‘regexp’ requires args >> satisfying ‘stringp’") > > It looks like (rx (regexp ...)) require namely literal, variables are > not supported yet. In additional (rx (literal ...)) is not supported > as well. > >> Eager macro-expansion failure: (error "Unknown rx form ‘literal’") > > In a couple of places `rx-to-string' likely could be used instead of > just `rx'. I have no idea yet what could be done with (pcase-let* ((rx > ...))) in `org-cite-adjust-note'. > >> diff --git a/lisp/oc-basic.el b/lisp/oc-basic.el Thanks. Could you send the patch again with a proper commit message, using git format-patch? Regards, -- Nicolas Goaziou
