A couple of additional remarks.

On 15/01/2022 19:52, Max Nikulin wrote:
On 02/01/2022 20:12, Ihor Radchenko wrote:

Subject: [PATCH] make test: Make failure results more verbose

At first it was not clear to me that only *summary* of test results is affected.

Should not the variable be named BTEST_ERT_VERBOSE_SUMMARY instead of just BTEST_ERT_VERBOSE due to this reason?

I am unsure if this line or local.mk has priority. I am unsure the the
following is better as well.
BTEST_ERT_VERBOSE ?= yes

I am not very familiar with Makefile conventions. Just followed the
existing settings in the same file. All other BTEST_ERT_* settings just
use "=".

I have found an example when "?=" is better. It is possible to export BTEST_ERT_VERBOSE from shell (or set in in the environment of continuous integration runner) and the value will not be overridden. Quick tests shell equivalent:

BTEST_ERT_VERBOSE= make test

currently it have to be written only as

make test-dirty BTEST_ERT_VERBOSE=


Reply via email to