Hey Ihor!
Ihor Radchenko <yanta...@gmail.com> writes:
> This is the final version of the patch. I am going to merge it this
> weekend. If there are any comments, please send them ASAP.
I've thrown a couple of LOGBOOK-heavy Org files at your branch; I'm
observing something that I can't make sense of. I tried to condense one
of these files into a small reproducer, see attached file; couldn't find
the time to make it smaller, sorry!
My recipe (based on commit f9dd109bc, Emacs 29.0.50 commit 864c8013fd):
$ git switch feature/org-fold-universal-core-tidy
$ make autoloads
$ emacs -Q -L lisp -eval "(setq org-startup-folded t)" repro.org
Restarting Emacs with the above between each step:
(1) C-s abc ⇒ no logbook is unfolded,
(2) C-s def ⇒ no logbook is unfolded,
(3) C-s ghi ⇒ some logbooks are unfolded.
Assuming you can reproduce: is it expected that logbooks are expanded in
case (3)? I don't see what's "conceptually" different in situation (3)
vs. (1) and (2), so I'm puzzled to get different results.
Also, a bit of idle curiosity:
> (defun org-fold--isearch-reveal (&rest _)
> "Reveal text at POS found by isearch."
> (org-fold-show-set-visibility 'isearch))
org-fold-show-set-visibility calls either
org-fold-show-set-visibility--overlays, or
org-fold-show-set-visibility--text-properties, and AFAICT neither of
these handle 'isearch as an argument… Is there a (cdr (assq 'isearch
org-fold-show-context-detail)) missing?
(This comes from a very cursory reading of the code; apologies if I've
missed something)
Other than this logbook oddity, I haven't found anything concerning.
Thanks for your efforts!
* xxxxxxxxxxx xxxx
:LOGBOOK:
CLOCK: [2021-11-02 Tue 17:18]--[2021-11-02 Tue 17:25] => 0:07
:END:
** xxx xxx xxxxx
*** xxxx [[xxxx:xxxxxxx/xxxxxxxxxx/xxxxxxxxxxxxxxxxx]]
:LOGBOOK:
CLOCK: [2021-11-03 Wed 13:51]--[2021-11-03 Wed 14:13] => 0:22
CLOCK: [2021-11-03 Wed 11:52]--[2021-11-03 Wed 12:00] => 0:08
CLOCK: [2021-11-03 Wed 11:27]--[2021-11-03 Wed 11:42] => 0:15
CLOCK: [2021-11-03 Wed 09:06]--[2021-11-03 Wed 10:04] => 0:58
CLOCK: [2021-11-02 Tue 18:11]--[2021-11-02 Tue 18:45] => 0:34
CLOCK: [2021-11-02 Tue 17:36]--[2021-11-02 Tue 17:38] => 0:02
CLOCK: [2021-11-02 Tue 17:25]--[2021-11-02 Tue 17:31] => 0:06
:END:
- [ ] xxxxx://xxxx.xx.xxxxxxx.xxx/xxxxxxx/xxxx xxxx?
(xxxx.xx xxxxx xx xxxxxxx)
- 🙌
- "xxxxxxx abc xxx xxxxxxxx xxxxxxxxxx"
**** [[xxxxx://xxxxxxxx.xxxxxxx.xxx/xxx/#/xxxxxxxxxxx/][xxx xxxxxxx xxxx xxxxxxxxxxx]]
**** [[xxxxx://xxxx.xxxxxxx.xxx/xxxxxxx/xxxxxxxxxx/xxxxxxxxxxxxxxxxx#xxxxx-xxx-xxxxxx-xxxxxx][xxxxx xxx xxxxxx xxxxxx]]
**** [[xxxxx://xxxx.xxxxxxx.xxx/xxxxxxx/xxxxxxxxxx/xxxxxxxxxxxxxxxxx#xxxxxx-xxxxxxxxxx][xxxxxx xxxxxxxxxx]]
- def xxxxxxxxxx:
- x (xxxxxxxx)
- x (xxxxxxxx)
**** [[xxxxx://xxxx.xxxxxxx.xxx/xxxxxxx/xxxxxxxxxx/xxxxxxxxxxxxxxxxx#xxxx-xxxx-xxx-xxxxxxx-xxxxx][xxxxxxx xxxxxxxxxxx]]
xxxxxx xx xxx xx xxxxxxxxxxx xxxxxxx? ⇒
xxxxxxx-xxxxxxxxx...@xxxxxxx.xxx
**** [[xxxx:xxxxxxxxxxxx]]
xxxxxxxx: ~xxxxxxx.xxxx.xxx:/xxxxxxx/xxxx-xxxx~
*** xxxx [[xxxxx://xxxx.xxxxxx.xxx/xxxxxxxx/x/xxxxxxxxxxxxxxxxxxx-xxxxxxxxxxxxxxxxxxxxxxxx/xxxx][xxxxxxxxxx xxxxxxx]]
:LOGBOOK:
CLOCK: [2021-11-03 Wed 15:13]--[2021-11-03 Wed 15:14] => 0:01
CLOCK: [2021-11-03 Wed 14:55]--[2021-11-03 Wed 14:57] => 0:02
:END:
*** xxxx [[xxxxx://xxxx.xxxxxx.xxx/xxxxxxxx/x/xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/xxxx][xxxx xxx xx xx xxx xxx]]
:LOGBOOK:
CLOCK: [2021-11-03 Wed 15:14]--[2021-11-03 Wed 15:17] => 0:03
:END:
*** xxxx [[xxxxx://xxxx.xxxxxx.xxx/xxxxxxxx/x/xxxxxxxxxxxxxxxxxxxxxxxxxx_xxxxxxxxxxxxxxxxx/xxxx][xxxxxx xx xxxxxxx xxxxxxx]]
:LOGBOOK:
CLOCK: [2021-11-03 Wed 16:00]--[2021-11-03 Wed 16:30] => 0:30
:END:
*** xxxx [[xxxx:xxxxxxx/xxxxxxxxxxxx]]
:LOGBOOK:
CLOCK: [2021-11-05 Fri 11:02]--[2021-11-05 Fri 11:18] => 0:16
CLOCK: [2021-11-05 Fri 09:42]--[2021-11-05 Fri 09:55] => 0:13
CLOCK: [2021-11-04 Thu 18:30]--[2021-11-04 Thu 18:32] => 0:02
CLOCK: [2021-11-04 Thu 12:07]--[2021-11-04 Thu 12:14] => 0:07
CLOCK: [2021-11-04 Thu 11:10]--[2021-11-04 Thu 12:00] => 0:50
CLOCK: [2021-11-03 Wed 18:11]--[2021-11-03 Wed 18:20] => 0:09
:END:
- xxxx :: xxxxxxx + xxxxxxxxxxxxxxxx
- xxxxxx :: xxxx xxxxxxxx xx xxxxxxxx xxxxxxx
- xxxxxxx xxx "xxxxxxxxxx":
- xxxxx xx xx xxxxxxxxxxxxxxxx xxxx xxxxxxxxx
- xxx xxxxxx xxx ∈ >x xxxxxxx
- xxxx :: xxxxxx xxxxxx xxxxxxxx xxxxxxx + xxxxxxxxxxxxxxxx
- xxxxxx xxxxxx xxxxxxxxx xxx xxxxxxxxx
- xxxxxx xxxxxx xxxx xxxxxxxxxx
- xxxxxxx :: xxxxx/xxxx/xxxxxx xxxxxxxxx
- xxxxxxxx xxxxxxxx xxxxxx
- 🙌
- [[xxxx:xxxxxxx/xxxxxxxxxxxx/xxxxxxxxxxx]]
- "xxxx xxx xxxxxxxx: xx xxx xxxxx xxxxxxx xxxxxxxxxxx, xxxx xxxx
xxxxxx xxxxx xxxxx xxxxxxxx"
- "xx xxx xxxx xxxxxxxxxx xxxxx xxxx xx xxxx xxxxxxx"
- [[xxxxx://xxxx.xxxxxx.xxx/xxxxxxxxxxxx/x/xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/xxxx#xxx=xxxxxxxxx][xxxxxxx xxxxx xxxxxxxxxxx]]
- "xxxx xxxxxxxxxxx xx xxxxxxxx xx xxxxxxxxx xxxxxxx xxxx xxxxxxxx
xxxxx xxxxxxxxxxx"
- [[xxxxx://xxx.xxxxxxx.xxx/xxxxxxx/xxxx-xx-xxxxxxx][xxxx xx xxxxxxx]]
(xxxxx xxx <xxxxx/xx#xxxxxx xxxxxxxxxx xxxxxx>)
*xxxxxxxx* :
- xxxxx://xxxx.xxxxxxx.xxx/xxxxxxx/xxxxxxxxxxxx/x&x
**** [[xxxxx://xxxx.xxxxxx.xxx/xxxxxxxx/x/xxxxxxxxxxxxxxxxxxxxxx-xxxxxxxxxxx_xxxxxxxxx/xxxx#][xxxxxx — xxxxxxxxxx xxx xxxxxxxxxxxx]]
:LOGBOOK:
CLOCK: [2021-11-05 Fri 09:55]--[2021-11-05 Fri 10:00] => 0:05
:END:
**** [[xxxx:xxxxxxx/xxxxxxxxxxxx/xxxxx/xx]]
:LOGBOOK:
CLOCK: [2021-11-08 Mon 13:20]--[2021-11-08 Mon 13:21] => 0:01
CLOCK: [2021-11-05 Fri 11:02]--[2021-11-05 Fri 11:02] => 0:00
CLOCK: [2021-11-05 Fri 10:29]--[2021-11-05 Fri 10:45] => 0:16
CLOCK: [2021-11-05 Fri 10:00]--[2021-11-05 Fri 10:23] => 0:23
:END:
*** xxxx [[xxxx:xxxxxxx/xxxxxxxxxx/xxx/xxxxxxx_xxxx/xxxxxxxxxxxxx][xxx xxxx xxxxxxx xxxxxx]]
:LOGBOOK:
CLOCK: [2021-11-05 Fri 15:25]--[2021-11-05 Fri 15:27] => 0:02
CLOCK: [2021-11-05 Fri 14:30]--[2021-11-05 Fri 14:47] => 0:17
CLOCK: [2021-11-05 Fri 13:47]--[2021-11-05 Fri 13:47] => 0:00
CLOCK: [2021-11-05 Fri 11:35]--[2021-11-05 Fri 11:37] => 0:02
CLOCK: [2021-11-05 Fri 11:18]--[2021-11-05 Fri 11:25] => 0:07
:END:
**** [[xxxx:xxxxxxx/xxxxxxxxxx/xxx/xxxxxxx_xxxx/xxxxxxxxxxxxxx][xxxx xxxxxxxxxx]]
:LOGBOOK:
CLOCK: [2021-11-05 Fri 13:47]--[2021-11-05 Fri 14:30] => 0:43
:END:
- 🤯
- [[xxxxx://xxxx.xxxxxx.xxx/xxxxxxxxxxxx/x/xxxxxxxxxxxxxxxxxxxxxxxx-xxxxxxxxxxxxxxxxxxx/xxxx#xxx=xxxxxxxxx][xxxxxxxxxxx xxxxxxxx & xxxx xxxxx]]: xxxxx xxxx xx xxx xxxxxxxxxxxx
**** [[xxxxx://xxxx.xxxxxxx.xxx/xxxxxxx/xxxxxxxxxx/xxx/xxxxxxx_xxxx/xxxxxxxxxxxxxxxxx][xxxxxxx xxxxxxxxxx]]
:LOGBOOK:
CLOCK: [2021-11-05 Fri 14:47]--[2021-11-05 Fri 15:04] => 0:17
:END:
- 👍 ghi xxxxxxxxxx & xxxxxxxxxx xxxx
