On Fri, Jun 17, 2022 at 11:09 PM Ihor Radchenko <yanta...@gmail.com> wrote:
> Ihor Radchenko <yanta...@gmail.com> writes:
>
> > Allen Li <darkfel...@felesatra.moe> writes:
> >
> >> On Sat, Jan 1, 2022 at 9:31 AM Allen Li <darkfel...@felesatra.moe>
> wrote:
> >>
> >>> It seems like the right fix here is to make - behave the same as -1,
> and
> >>> raise a user error for any other negative numeric prefix, since it is
> >>> likely not doing whatever the user wanted.
> >>>
> >>
> >> Attached a small patch fixing this, which I tested manually.
>
> Applied onto main via bfd63cc4f.
>
> Would you also be interested to write a test checking org-todo ARGS?
>
Attached
>
> Best,
> Ihor
>
From 9255819ee05b9f2bdbe8de1cf0acbd6ae6553152 Mon Sep 17 00:00:00 2001
From: Allen Li <darkfel...@felesatra.moe>
Date: Sat, 25 Jun 2022 21:27:20 -0700
Subject: [PATCH] test-org: Add test for org-todo prefix behavior
* testing/lisp/test-org.el (test-org/org-todo-prefix): Add test.
---
testing/lisp/test-org.el | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/testing/lisp/test-org.el b/testing/lisp/test-org.el
index 121f9efd5..304dddc08 100644
--- a/testing/lisp/test-org.el
+++ b/testing/lisp/test-org.el
@@ -7753,6 +7753,25 @@ CLOSED: %s
(org-add-log-note))
(buffer-string))))))
+(ert-deftest test-org/org-todo-prefix ()
+ "Test `org-todo' prefix arg behavior."
+ ;; -1 prefix arg should cancel repeater and mark DONE.
+ (should-not
+ (string-prefix-p
+ "* TODO H"
+ (let ((org-todo-keywords '((sequence "TODO" "DONE"))))
+ (org-test-with-temp-text "* TODO H\n<2012-03-29 Thu +2y>"
+ (org-todo -1)
+ (buffer-string)))))
+ ;; - prefix arg should cancel repeater and mark DONE.
+ (should-not
+ (string-prefix-p
+ "* TODO H"
+ (let ((org-todo-keywords '((sequence "TODO" "DONE"))))
+ (org-test-with-temp-text "* TODO H\n<2012-03-29 Thu +2y>"
+ (org-todo '-)
+ (buffer-string))))))
+
;;; Timestamps API
--
2.36.1
