Robert Pluim <rpl...@gmail.com> writes:

>>>>>> On Mon, 27 Jun 2022 17:53:30 +0800, Ihor Radchenko <yanta...@gmail.com> 
>>>>>> said:
>
>     Ihor> Robert Pluim <rpl...@gmail.com> writes:
>     >> diff --git a/org-contribute.org b/org-contribute.org
>
>     Ihor> Maybe add the details to org-maintenance.org instead?
>     Ihor> This is more of a technical detail needed for maintainers, not for 
> the
>     Ihor> committers.
>
> Iʼd be worried if the org maintainer(s) didnʼt know how to override
> Author :-)

I have bad news for you... Simply because I never ever had a need to do
it :) Not like selecting this option from Magit dispatch is difficult.

> Occasional committers would probably not read org-maintenance.org, and
> those are the people this section is aimed at, I think. Plus itʼs the
> kind of thing you need to catch early: once the commit has been pushed
> itʼs too late.

Not really. org-contribute.org is the page directly linked from
orgmode.org. It is aiming for new contributors with no write access.

More elaborate things like backwards compatibility, copyright process
assistance, etc are documented in org-maintenance.org.
Modifying submitted diffs/patches appears to lay within the more
elaborate category IMHO.

>     >> +1. Command line: src_sh{git commit --author='First Last 
> <fl...@somewhere.com>'}
>
>     Ihor> I think we usually prefer source blocks to inline source blocks.
>
> OK, changed.
>
>     >> +2. =VC=: Set the 'Author:' field in log-edit mode (requires setting
>     >> +   `log-edit-setup-add-author').
>
>     Ihor> 'Author:' -> =Author:=
>     Ihor> `log-edit-setup-add-author' -> ~log-edit-setup-add-author~ 
>
> OK, changed.

I guess that you intended to attach the updated patch, but haven't?

Best,
Ihor

Reply via email to