Mikhail Skorzhinskii <mskorzhins...@eml.cc> writes: > Thank you for the review, appreciate your comments. I've applied your > suggestions. Please find the fixed file in the attachment to this > letter.
It took a while, but Applied onto main via 31b3b164d after adding a TINYCHANGE cookie to the commit message (AFAIK, you haven't signed the FSF copyright assignment). https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=31b3b164d100362365bd301d44a838cdf1059109 > There is one important note that about this patch. There is one corner > case: when we've set org-icalendar-force-alarm variable to nil, org- > icalendar-alarm-time variable to non-nil and the APPT_WARNTIME property > is set to 0, then, with my code, the value of the org-icalendar-alarm- > time would be used. > > Basically if user is not forcing the 'zero alarms', and has some non- > zero default value for alarms, the APPT_WARNTIME property will use > default alarm. Which is something, I would say, unexpected. I would > expect that alarm will be shut-off. > > However I am just keeping the previous behaviour. I think its worth > fixing, but I'd say we do this in a separate patch. Sounds reasonable. Feel free to share a patch if you are still interested. However, note that you applied patch is ~15LOC and FSF copyright assignment may be needed. See https://orgmode.org/worg/org-contribute.html#copyright Best, Ihor