Ihor Radchenko writes:
> I do recall Nicolas repeatedly voicing against usage of subr-x staff:
>
> https://orgmode.org/list/87wo4en8qk....@nicolasgoaziou.fr
>>>> 2. we don't use "subr-x.el" in the code base. In particular, it
>>>> would be
>>>> nice to replace `when-let' with `when' + `let'. This change costs
>>>> only one loc.
>
> However, he did not mention the reasoning behind this, except a single
> massage I was able to find:
>
> https://orgmode.org/list/8737t0b2c9....@nicolasgoaziou.fr
>>>> ... you are not using `if-let' anywhere if this patch. Besides, we still
>>>> cannot use subr-x, since it is a 24.4 library, and, AFAIR, we didn't
>>>> drop support for 24.3 yet.
>
> If supporting Emacs 24 is the only blocker for subr-x, it should be safe
> to use it.
Right, as far as I understand, support for Emacs 24.3 was the main
reason to avoid it; subr-x.el wasn't added until Emacs 24.4, when it was
renamed from helpers.el. (There may be the general stylistic question
of whether to use when-let{,*} and friends, but that's not relevant in
this context.)
I've pushed 04d9d4b3d, but please feel free to adjust as needed if some
other reason to avoid loading subr-x surfaces.
