Chris Clark <cfc...@gmail.com> writes: > This is my first attempt to contribute to org-mode; please let me know if > I'm doing something wrong.
Thanks a lot! Contributions are always welcome. Please also add a mention and/or example to the ob-clojure documentation https://orgmode.org/worg/org-contrib/babel/languages/ob-doc-clojure.html (The source repository is https://git.sr.ht/~bzg/worg ) Also, you need to add an etc/ORG-NEWS entry about the new header argument. And I have few minor comments on the patch itself. > From cc72dcac3075be76e3edcfee75c887272e48698c Mon Sep 17 00:00:00 2001 > From: Chris Clark <cfc...@gmail.com> > Date: Sat, 8 Oct 2022 05:41:20 -0400 > Subject: [PATCH] ob-clojure.el: Add a 'backend' header arg to clojure code > blocks ^:backend > * ob-clojure.el (org-babel-header-args:clojure, > org-babel-execute:clojure): Add a 'backend' header arg that can ^:backend > override the configured `org-babel-clojure-backend`. ^' (by convention, we quote like `symbol' using `' pair). Also, unless you have FSF copyright assignment, we need you to add TINYCHANGE at the end of the commit message. See https://orgmode.org/worg/org-contribute.html#first-patch > + (t (user-error "You need to customize > org-babel-clojure-backend"))))) While we are here, can as well quote `org-babel-clojure-backend'. Or may even add "or set `:backend' header argument". -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
