dzilte...@lyrion.ch writes: > From: Daniel Ziltener <dzilte...@lyrion.ch> > > * ob-tangle.el, ob-core.el, test-ob-tangle.el, org-manual.org: Add a > "strip-tangle" noweb option to strip the noweb tags when tangling, but > keep and expand them otherwise.
Thanks for the patch! If I understand correctly, you are suggesting Could you please follow https://orgmode.org/worg/org-contribute.html#commit-messages for the commit log entries? Also, do you have FSF copyright assignment? If no, you also need to add TINYCHANGE cookie to the commit message. See https://orgmode.org/worg/org-contribute.html#first-patch > +- =strip-tangle= :: > + > + Expansion of noweb syntax references in the body of the code block > + when evaluating or exporting. Removes noweb syntax references > + when tangling. This is a new feature and thus should also be mentioned in etc/NEWS. Also, please use double space between sentences. See doc/Documentation_Standards.org. > (let ((allowed-values (cl-case context > - (:tangle '("yes" "tangle" "no-export" "strip-export")) > - (:eval '("yes" "no-export" "strip-export" "eval")) > - (:export '("yes"))))) > + (:tangle '("yes" "tangle" "no-export" "strip-export" > "strip-tangle")) > + (:eval '("yes" "no-export" "strip-export" "eval" > "strip-tangle")) > + (:export '("yes" "strip-tangle"))))) AFAIU, you are suggesting a new value for :noweb header argument. But this function has nothing to do with :noweb. This change will check for :tangle strip-tangle, :eval strip-tangle, and :export strip-tangle. What is the purpose? Also, the allowed values of standard header args are defined in org-babel-common-header-args-w-values, which you did not change. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>