Pedro Andres Aranda Gutierrez <paag...@gmail.com> writes:
> thanks for the patience. I have a comment on the message you refer to... If
> comes from 2014.
>
> So I have resorted to my fresh Emacs29, opened it with emacs -Q for a clean
> environment.
> ...
> In my most humble opinion, I looks like the global \lstset{} isn't used and
> that the caption/label is set locally. And this makes me believe that
> label= or caption= are not very useful.
I guess it is after
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=6ef33b6dd
If the cited issue is no longer need to be accounted for, your version
should be fine.
> I'm attaching the patch generated with git diff -p.
> Mea culpa, I should have RTFM before sending anything :-)
For the final version of the patch, you may better follow
https://orgmode.org/worg/org-contribute.html#orgbc683f3 to create a
.patch file. The .patch file will include your authorship. Do not forget
the changelog entry.
> +(defcustom org-latex-listings-src-omit-language nil
> + "Set this option to t to omit the
> +\"language=\"
> +in the parameters to \\begin{lstlisting} when exporting a src block"
> + :group 'org-export-latex
> + :version "30.0"
> + :package-version '(Org . "9.7")
> + :type 'boolean
> + )
Please do not leave handing ")" on separate lines. It is against common
Elisp style conventions. See D.1 Emacs Lisp Coding Conventions section
of Elisp manual:
• Don’t make a habit of putting close-parentheses on lines by
themselves; Lisp programmers find this disconcerting.
> + (when label ; label= w/o label makes little sense
> + `(("label" ,(org-latex--label src-block info))))
> + (when caption-str ; caption= w/o caption makes little
> sense
> + `(("caption" ,caption-str))
> + `(("captionpos" ,(if caption-above-p "t" "b")))) ; as does
> captionpos w/o caption
These comments are not really needed. Actually, it is that `if' that
deserved explanation. Not putting empty caption/label is intuitive.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
