Despite the unfortunate lack of a maintainer, I hope the (latest
version of the) patch can still be applied as the current behavior of
ob-scheme.el, namely, silencing any evaluation errors is infeasible.

Do you need any FSF copyright assignments from me? (I already
contributed to GCC and Gnulib under such an assignment in the past.)

Thanks,

Marc

Am Mo., 2. Jan. 2023 um 10:52 Uhr schrieb Marc Nieper-Wißkirchen
<m...@nieper-wisskirchen.de>:
>
> Am Mo., 2. Jan. 2023 um 10:38 Uhr schrieb Ihor Radchenko 
> <yanta...@posteo.net>:
> >
> > Marc Nieper-Wißkirchen <m...@nieper-wisskirchen.de> writes:
> >
> > > Fixed.
> >
> > Thanks!
> > Note that your patch does not apply onto main.
>
> Rebased against the latest main.  Please see the appended patch.
>
> >
> > > -           (setq result (if output
> > > +              (let ((err (geiser-eval--retort-error ret)))
> > > +                (setq result (cond
> > > +                              (err nil)
> >
> > We may still provide output, if any. Even in the case of error. Not sure
> > if it makes sense for ob-scheme though.
>
> I switched the two cases, "err" and "output," in the attached patch.
> For a value result, providing a result in case of an error does not
> make sense.
>
> Thanks for your patience,
>
> Marc

Reply via email to